modified header to look like mock #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns: inbox, notification and profile
esteban-gs
reviewed
Sep 16, 2023
esteban-gs
reviewed
Sep 16, 2023
esteban-gs
reviewed
Sep 16, 2023
esteban-gs
approved these changes
Sep 16, 2023
There was a problem hiding this comment.
@alexislcstone , Thanks for working on this! I added a couple of comments for improvements.
I think we could also benefit from splitting up Header into smaller components, but up to you if want to tackle it in this PR.
Totally think it is a good idea but rather leave it for another sprint or for someone else to split; there is some refactoring too I can see to clean things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'modified header to look like mock - used user, if defined, to show icons: inbox, notification and profile'