Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 288 org sign up screens #348

Merged
merged 44 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
332b652
added IRS classification dropdown to new org signup UI
denniswangcodes May 2, 2023
f854cbc
updated steps to Figma design 90% similarity
denniswangcodes May 9, 2023
03813ac
minor text rearrangement
denniswangcodes May 9, 2023
e3b187f
repurposed 306-sign-in-modal modal logic for signup.tsx
denniswangcodes Jun 8, 2023
a7a1ada
added back sample.env file
denniswangcodes Jun 8, 2023
97e0cc9
Put back old code in signupuserandnonprofit.tsk to resolve conflict
denniswangcodes Jun 8, 2023
920866f
Merge branch 'main' into feature-288-org-sign-up-screens
denniswangcodes Jun 8, 2023
2a12165
Modal working, test modal opens closes successfully
EtoKruto Jun 11, 2023
9d9c153
Modal handleClickOutisde still not working, otherwise removed paths t…
EtoKruto Jun 12, 2023
96fcda8
Co-authored-by: Alex <[email protected]>
denniswangcodes Jun 13, 2023
f8250ac
finalized css of the modal, added handleClose function on URL change …
EtoKruto Jun 17, 2023
374bc2b
resolved comments, removed google and facebook buttons, changed color…
EtoKruto Jun 22, 2023
64ae30a
resolution of conflicts from main
EtoKruto Jun 23, 2023
7e49c49
fixed merge conflicts and typescritp conflicts
EtoKruto Jun 23, 2023
3313ca5
added modal for join now in header
denniswangcodes Jul 6, 2023
6ab8ec8
fixed bug login.tsk path undefined
denniswangcodes Jul 7, 2023
fd4bc51
Merge remote-tracking branch 'origin/306-sign-in-and-modal-new' into …
denniswangcodes Jul 27, 2023
3782c66
Linked modal logic to home page's Join Now CTA Button
denniswangcodes Jul 27, 2023
d718f33
Fixed styling of pop up modal buttons and divider
denniswangcodes Jul 27, 2023
b2d0d16
refactored steps UI to match figma text fields
denniswangcodes Aug 4, 2023
541578e
decluttered imports
denniswangcodes Aug 4, 2023
ee6a7bd
added org online contact information page
denniswangcodes Aug 7, 2023
4558783
decluttered imports and updated text in signupmodal
denniswangcodes Aug 7, 2023
f9b500b
added already have account and display signup profile logic
denniswangcodes Aug 10, 2023
a3c8ff7
Merge branch 'main' into feature-288-org-sign-up-screens
denniswangcodes Aug 11, 2023
c0baf62
improved inut label appearance & sign in click
denniswangcodes Aug 28, 2023
71e27c3
changed signinmodal.tsx signup button
denniswangcodes Aug 30, 2023
40aefc6
Merge branch 'feature-288-org-sign-up-screens' of https://github.com/…
denniswangcodes Aug 30, 2023
60ed47a
added disable next until fields completed logic
denniswangcodes Sep 2, 2023
1af1dc3
added chip select color change logic
denniswangcodes Sep 5, 2023
6b3329b
refined next button logic
denniswangcodes Sep 5, 2023
b09fc34
removed sign up button on final page
denniswangcodes Sep 21, 2023
9a05301
added ts ignore 405
denniswangcodes Sep 22, 2023
224654c
Merge branch 'main' into feature-288-org-sign-up-screens
denniswangcodes Sep 22, 2023
2470298
test
denniswangcodes Sep 22, 2023
44861d3
refactored view and component file structure
denniswangcodes Oct 27, 2023
21fab88
updated focusAreas tsx to FocusArea tsx
denniswangcodes Oct 27, 2023
766505b
refactoring to parent child structure
denniswangcodes Nov 2, 2023
5cd3e27
Merge branch 'main' into feature-288-org-sign-up-screens
denniswangcodes Nov 2, 2023
6ea7824
finished refactoring parent child component structure
denniswangcodes Nov 3, 2023
bd646b0
removed unused things
denniswangcodes Nov 3, 2023
70afb6f
removed linter for unused things
denniswangcodes Nov 3, 2023
33b45a7
completed refactoring of all five steps children components
denniswangcodes Nov 9, 2023
d009704
minor cleanup after refactor
denniswangcodes Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .husky/pre-push

This file was deleted.

15 changes: 12 additions & 3 deletions client/src/components/BannerSection.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import React, { useContext } from 'react';
import { Grid, Typography, Box } from '@mui/material';
import { makeStyles } from 'tss-react/mui';
import type { Theme } from '@mui/material/styles';
import MainImage from '../assets/banner-section-main.svg';
import { CTAHeroButton } from './Buttons/Button';
import { useHistory } from 'react-router-dom';
import { ModalContext } from './../providers/ModalProvider';

const useStyles = makeStyles()((theme: Theme) => ({
gridTitle: {
Expand Down Expand Up @@ -44,15 +45,23 @@ function BannerText() {

function BannerSection() {
const { classes } = useStyles();
const history = useHistory();
const modalContext = useContext(ModalContext);
const { openModal } = modalContext;
denniswangcodes marked this conversation as resolved.
Show resolved Hide resolved

const handleOpenModal = (modalType: 'SignIn' | 'SignUp') => {
if (modalType === 'SignIn') {
openModal('SignIn');
} else if (modalType === 'SignUp') {
openModal('SignUp');
}
};
return (
<Box>
<Grid container spacing={3} sx={{ height: '600px' }}>
<Grid xs={6} item justifyContent="center" sx={{ display: 'flex' }}>
<Box sx={{ width: '550px', mt: '180px', mb: '66px', ml: '40px' }}>
<BannerText />
<CTAHeroButton text="Join Now" onClick={() => history.push('/signup-citizen')} />
<CTAHeroButton text="Join Now" onClick={() => handleOpenModal('SignUp')} />
denniswangcodes marked this conversation as resolved.
Show resolved Hide resolved
</Box>
</Grid>
<Grid
Expand Down
45 changes: 45 additions & 0 deletions client/src/components/Buttons/CTAButton.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denniswangcodes , this should already be implemented on the main branch. See:

export function CTAHeroButton({ text, onClick }: Props) {

Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { makeStyles } from 'tss-react/mui';
import { Typography } from '@mui/material';
import type { Theme } from '@mui/material/styles';
import React, { useContext } from 'react';
import { ModalContext } from '../../providers/ModalProvider';

const useStyles = makeStyles()((theme: Theme) => ({
CTAButton: {
color: 'white',
backgroundColor: '#EF6A60',
borderRadius: '10px',
fontFamily: 'Poppins',
fontWeight: 'semi-bold',
border: 'none',
'&:hover': {
backgroundColor: '#EF6A60',
cursor: 'pointer',
},
},
}));

type Props = {
text: string;
};

function CTAButton({ text }: Props) {
const { classes } = useStyles();
const modalContext = useContext(ModalContext);
esteban-gs marked this conversation as resolved.
Show resolved Hide resolved
const { openModal } = modalContext;
denniswangcodes marked this conversation as resolved.
Show resolved Hide resolved

return (
<button onClick={() => openModal('SignUp')} className={classes.CTAButton}>
<Typography
sx={{
fontSize: '22px',
padding: '15px 25px 15px 25px',
}}
>
{text}
</Typography>
</button>
);
}

export default CTAButton;
7 changes: 3 additions & 4 deletions client/src/components/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function Header() {
const modalContext = useContext(ModalContext);
const { openModal } = modalContext;

const handleoOpenModal = (modalType: 'SignIn' | 'SignUp') => {
const handleOpenModal = (modalType: 'SignIn' | 'SignUp') => {
if (modalType === 'SignIn') {
openModal('SignIn');
} else if (modalType === 'SignUp') {
Expand Down Expand Up @@ -489,12 +489,11 @@ function Header() {
</>
) : (
<>
{/* TODO: Use () => handleoOpenModal('SignUp') when implemented */}
<PrimaryCTAButton
text="Join Now"
onClick={() => history.push('/signup-citizen')}
onClick={() => handleOpenModal('SignUp')}
></PrimaryCTAButton>
<Button className={classes.signInButton} onClick={() => handleoOpenModal('SignIn')}>
<Button className={classes.signInButton} onClick={() => handleOpenModal('SignIn')}>
Sign In
</Button>
</>
Expand Down
Loading
Loading