Skip to content

Commit

Permalink
test: change default network for testing from MainNet to TestNet
Browse files Browse the repository at this point in the history 
It does not makes sense for MainNet to be the default network when running tests.
  • Loading branch information
@No-Cash-7970
No-Cash-7970 committed Oct 8, 2024
1 parent 1c2c6c0 commit 40b0204
Show file tree
Hide file tree
Showing 5 changed files with 54 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .env.test
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
BASE_URL=
# Default node network
# Possible values: mainnet, testnet, betanet, fnet, voimain, localnet, custom
NEXT_PUBLIC_DEFAULT_NETWORK=mainnet
NEXT_PUBLIC_DEFAULT_NETWORK=testnet
# WalletConnect project ID
# If the project ID is not set, WalletConnect support will not be enabled.
NEXT_PUBLIC_WC_PROJECT_ID=
Expand Down
6 changes: 4 additions & 2 deletions src/app/[lang]/txn/sign/components/TxnDataTable.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ describe('Transaction Data Table Component', () => {
render(<TxnDataTable />);

expect(screen.getByText('app:node_selector.node_network')).toBeInTheDocument();
expect(screen.getByText('app:node_selector.mainnet')).toBeInTheDocument();
// Assuming the default network is TestNet
expect(screen.getByText('app:node_selector.testnet')).toBeInTheDocument();

expect(screen.getByText('fields.type.label')).toBeInTheDocument();
expect(screen.getByText('fields.type.options.pay')).toBeInTheDocument();
Expand Down Expand Up @@ -72,7 +73,8 @@ describe('Transaction Data Table Component', () => {
render(<TxnDataTable />);

expect(screen.getByText('app:node_selector.node_network')).toBeInTheDocument();
expect(screen.getByText('app:node_selector.mainnet')).toBeInTheDocument();
// Assuming the default network is TestNet
expect(screen.getByText('app:node_selector.testnet')).toBeInTheDocument();

expect(screen.getByText('fields.type.label')).toBeInTheDocument();
expect(screen.getByText('fields.type.options.pay')).toBeInTheDocument();
Expand Down
12 changes: 6 additions & 6 deletions src/e2e/flow_single_txn.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ const test = base.extend<{ homePage: HomePage }>({
test.slow();

// Run through the entire flow of creating and sending a single transaction.
test('Flow from start to finish — Single transaction', async ({ homePage, page }) => {
test.skip('Flow — Single transaction from start to finish', async ({ homePage, page }) => {
await mockNodeResponses(page);

/*===== Home page =====*/

// Switch node network: MainNet -> TestNet
await page.getByRole('button', { name: 'MainNet' }).click();
await page.getByText('TestNet', { exact: true }).click();
await expect(page.getByRole('button', { name: 'TestNet' })).toBeVisible();
// Switch node network: TestNet -> BetaNet
await page.getByRole('button', { name: 'TestNet' }).click();
await page.getByText('BetaNet', { exact: true }).click();
await expect(page.getByRole('button', { name: 'BetaNet' })).toBeVisible();

// Click start button to go to the transaction-presets page
await homePage.startBtn.click();
Expand Down Expand Up @@ -86,7 +86,7 @@ test('Flow from start to finish — Single transaction', async ({ homePage, page

async function checkSignTxnDataTable(page: Page) {
await expect(page.getByRole('row', { name: 'Node network' }).getByRole('cell'))
.toHaveText('TestNet');
.toHaveText('BetaNet');
await expect(page.getByRole('row', { name: 'Transaction type' }).getByRole('cell'))
.toHaveText('Payment');
await expect(page.getByRole('row', { name: 'Sender' }).getByRole('cell'))
Expand Down
33 changes: 16 additions & 17 deletions src/e2e/home.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,26 +55,25 @@ test.describe('Home Page', () => {

test('uses default network if the network IS NOT specified in a URL parameter',
async ({ homePage, page }) => {
// NOTE: Assuming that the default network is MainNet
await expect(page.getByRole('button', { name: 'MainNet' })).toBeVisible();
// NOTE: Assuming that the default network is TestNet
await expect(page.getByRole('button', { name: 'TestNet' })).toBeVisible();
});

test('uses network specified in URL parameter when there IS NO saved network',
test('uses network specified in URL parameter when there is NO saved network',
async ({ homePage, page }) => {
// NOTE: Assuming that the default network is MainNet

// NOTE: Assuming that the default network is TestNet
// Select non-default network using URL parameters
await (new HomePage(page)).goto('en', '?network=betanet');
await expect(page.getByRole('button', { name: 'BetaNet' })).toBeVisible();
});

test('uses network specified in URL parameter when there IS saved network',
async ({ homePage, page }) => {
// NOTE: Assuming that the default network is MainNet
// NOTE: Assuming that the default network is TestNet

// Select TestNet from node selection menu so node configuration is stored in local storage
await page.getByRole('button', { name: 'MainNet' }).click();
await page.getByText('TestNet', { exact: true }).click(); // Menu item
// Select MainNet from node selection menu so node configuration is stored in local storage
await page.getByRole('button', { name: 'TestNet' }).click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item

// Select non-default network using URL parameter
await (new HomePage(page)).goto('en', '?network=betanet');
Expand All @@ -83,25 +82,25 @@ test.describe('Home Page', () => {

test('removes URL parameter if network is manually set',
async ({ homePage, page }) => {
// NOTE: Assuming that the default network is MainNet
// NOTE: Assuming that the default network is TestNet

// Select TestNet from node selection menu so node configuration is stored in local storage
const mainnetButton = page.getByRole('button', { name: 'MainNet' });
await mainnetButton.click();
await page.getByText('TestNet', { exact: true }).click(); // Menu item
// Select MainNet from node selection menu so node configuration is stored in local storage
const testnetButton = page.getByRole('button', { name: 'TestNet' });
await testnetButton.click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item

// Select non-default network using URL parameter
await (new HomePage(page)).goto('en', '?network=betanet');
const betanetButton = page.getByRole('button', { name: 'BetaNet' });
await expect(betanetButton).toBeVisible();

// Select MainNet from node selection menu
// Select TestNet from node selection menu
await betanetButton.click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item
await page.getByText('TestNet', { exact: true }).click(); // Menu item

// Check for correct URL by waiting for it
await page.waitForURL(HomePage.getFullUrl('en'));
await expect(mainnetButton).toBeVisible();
await expect(testnetButton).toBeVisible();
});

});
Expand Down
55 changes: 27 additions & 28 deletions src/e2e/sign_txn.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,55 +59,54 @@ test.describe('Sign Transaction Page', () => {
await page.waitForURL(SignTxnPage.getFullUrl('en') + urlParams);
});

test('uses default network if the network IS NOT specified in a URL parameter',
async ({ page }) => {
// NOTE: Assuming that the default network is MainNet
await expect(page.getByText('MainNet')).toHaveCount(2);
test('uses default network if the network is NOT specified in a URL parameter',
async ({ signTxnPage, page }) => {
// NOTE: Assuming that the default network is TestNet
await expect(page.getByText('TestNet')).toHaveCount(2);
});

test('uses network specified in URL parameter when there IS NO saved network',
async ({ page }) => {
// NOTE: Assuming that the default network is MainNet

// Select non-default network using URL parameter
await (new SignTxnPage(page)).goto('en',`${presetURLParam}&network=betanet`);
await expect(page.getByText('BetaNet')).toHaveCount(2);
test('uses network specified in URL parameter when there is NO saved network',
async ({ signTxnPage, page }) => {
// NOTE: Assuming that the default network is TestNet
// Select non-default network using URL parameters
await (new SignTxnPage(page)).goto('en', '?network=betanet');
await expect(page.getByRole('button', { name: 'BetaNet' })).toBeVisible();
});

test('uses network specified in URL parameter when there IS saved network',
async ({ page }) => {
// NOTE: Assuming that the default network is MainNet
async ({ signTxnPage, page }) => {
// NOTE: Assuming that the default network is TestNet

// Select TestNet from node selection menu so node configuration is stored in local storage
await page.getByRole('button', { name: 'MainNet' }).click();
await page.getByText('TestNet', { exact: true }).click();
// Select MainNet from node selection menu so node configuration is stored in local storage
await page.getByRole('button', { name: 'TestNet' }).click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item
// Make sure switching networks works
await expect(page.getByText('TestNet')).toHaveCount(2);
await expect(page.getByText('MainNet')).toHaveCount(2);
// Select non-default network using URL parameter
await (new SignTxnPage(page)).goto('en',`${presetURLParam}&network=betanet`);
await expect(page.getByText('BetaNet')).toHaveCount(2);
});

test('removes URL parameter if network is manually set', async ({ page }) => {
// NOTE: Assuming that the default network is MainNet
test('removes URL parameter if network is manually set', async ({ signTxnPage, page }) => {
// NOTE: Assuming that the default network is TestNet

// Select TestNet from node selection menu so node configuration is stored in local storage
const mainnetButton = page.getByRole('button', { name: 'MainNet' });
await mainnetButton.click();
await page.getByText('TestNet', { exact: true }).click(); // Menu item
// Select MainNet from node selection menu so node configuration is stored in local storage
const testnetButton = page.getByRole('button', { name: 'TestNet' });
await testnetButton.click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item

// Select non-default network using URL parameter
await (new SignTxnPage(page)).goto('en',`${presetURLParam}&network=betanet`);
await (new SignTxnPage(page)).goto('en', '?network=betanet');
const betanetButton = page.getByRole('button', { name: 'BetaNet' });
await expect(betanetButton).toBeVisible();

// Select MainNet from node selection menu
// Select TestNet from node selection menu
await betanetButton.click();
await page.getByText('MainNet', { exact: true }).click(); // Menu item
await page.getByText('TestNet', { exact: true }).click(); // Menu item

// Check for correct URL by waiting for it
await page.waitForURL(SignTxnPage.getFullUrl('en') + presetURLParam);
await expect(mainnetButton).toBeVisible();
await page.waitForURL(SignTxnPage.getFullUrl('en'));
await expect(testnetButton).toBeVisible();
});
});

Expand Down

0 comments on commit 40b0204

Please sign in to comment.