Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satdump: init at 1.2.2 #369540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

satdump: init at 1.2.2 #369540

wants to merge 3 commits into from

Conversation

theverygaming
Copy link

@theverygaming theverygaming commented Dec 31, 2024 •
edited
Loading

Closes: #314003

Packaged SatDump, a software to receive, decode and process data from satellites.

See https://www.satdump.org/about/ and https://github.com/SatDump/SatDump

Also https://repology.org/project/satdump/versions

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 31, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 31, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 31, 2024
@lucasew
Copy link
Contributor

lucasew commented Dec 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369540

x86_64-linux

✅ 1 package built:
  • satdump

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 31, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 31, 2024
@ofborg ofborg bot requested a review from nviets December 31, 2024 14:44
@lucasew
Copy link
Contributor

lucasew commented Dec 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369540

x86_64-linux

❌ 10 packages failed to build:
  • python312Packages.nipy
  • python312Packages.nipy.dist
  • python312Packages.niworkflows
  • python312Packages.niworkflows.dist
  • python312Packages.transforms3d
  • python312Packages.transforms3d.dist
  • python313Packages.nipy
  • python313Packages.nipy.dist
  • python313Packages.transforms3d
  • python313Packages.transforms3d.dist
✅ 5 packages built:
  • dotbot
  • dotbot.dist
  • nezha-theme-admin
  • nng
  • satdump

@theverygaming
Copy link
Author

theverygaming commented Jan 1, 2025 •
edited
Loading

@lucasew running nixpkgs-review pr 369540 for me only builds satdump and nng, both successfully.

@lucasew
Copy link
Contributor

lucasew commented Jan 1, 2025

@lucasew running nixpkgs-review pr 369540 for me only builds satdump and nng, both successfully.

It is happening sometimes
Mic92/nixpkgs-review#446

@JVital2013 JVital2013 mentioned this pull request Jan 4, 2025
Open
@Erethon
Copy link
Contributor

Erethon commented Jan 5, 2025

I'll let other people properly review this, but it compiles and works with an rtl-sdr for me, so LGTM and thank you for the packaging effort!

@lucasew
Copy link
Contributor

lucasew commented Jan 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369540

x86_64-linux

✅ 2 packages built:
  • nng
  • satdump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew Awaiting requested review from lucasew

@nviets nviets Awaiting requested review from nviets

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: SatDump
4 participants
@theverygaming @lucasew @Erethon @NixOSInfra