Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacsPackages.lsp-bridge: 0-unstable-2024-12-09 -> 0-unstable-2024-12-16 #365777

Merged
merged 1 commit into from
Dec 17, 2024
Merged

emacsPackages.lsp-bridge: 0-unstable-2024-12-09 -> 0-unstable-2024-12-16 #365777

merged 1 commit into from
Dec 17, 2024

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Dec 17, 2024 •
edited
Loading

Update to latest commit: manateelazycat/lsp-bridge@b73717e

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 17, 2024
jian-lin
jian-lin approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@kira-bruneau kira-bruneau merged commit 06c1b1f into NixOS:master Dec 17, 2024
31 of 32 checks passed
@ofborg ofborg bot requested a review from fxttr December 17, 2024 14:57
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jian-lin jian-lin jian-lin approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

@fxttr fxttr Awaiting requested review from fxttr

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kira-bruneau @jian-lin