Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noita-entangled-worlds: init at 0.32.5 #365769

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

noita-entangled-worlds: init at 0.32.5 #365769

wants to merge 2 commits into from

Conversation

Orbsa
Copy link

@Orbsa Orbsa commented Dec 17, 2024

Things done

Tested and working great on NixOS.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 17, 2024
@Orbsa Orbsa changed the title Init noita-entangled-worlds Init noita-entangled-worlds 0.32.5 Dec 17, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 17, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 17, 2024
@Orbsa
Copy link
Author

Orbsa commented Dec 17, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@Orbsa merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/

@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from b7d41f2 to 7d1ec87 Compare December 17, 2024 04:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 17, 2024
@Orbsa
Copy link
Author

Orbsa commented Dec 17, 2024

Why not build from source?

great question.
I had trouble implementing building from source and found it easier to just grab the release.
I can try again later tonight and see if I can get it working. I am pretty new at building a nix pkg.

rhendric
rhendric requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@rhendric rhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consolidate your commits and remember to format the commit message per the standard convention.

pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from 7d1ec87 to 3f58fdd Compare December 19, 2024 00:26
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 19, 2024
@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from 3f58fdd to fa03d13 Compare December 19, 2024 00:33
@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from fa03d13 to e23c910 Compare December 19, 2024 01:41
@rhendric
Copy link
Member

Looks good, but there are two stray commits in here. Clean those out and you've got my approval.

@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from e23c910 to c466736 Compare December 19, 2024 02:26
@github-actions github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 19, 2024
@Orbsa
Copy link
Author

Orbsa commented Dec 19, 2024

Looks good, but there are two stray commits in here. Clean those out and you've got my approval.

must have been a rebase issue. Removed

@donovanglover donovanglover changed the title Init noita-entangled-worlds 0.32.5 noita-entangled-worlds: init at 0.32.5 Dec 19, 2024
donovanglover
donovanglover previously requested changes Dec 19, 2024
View reviewed changes
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/noita-entangled-worlds/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 19, 2024
@Orbsa Orbsa force-pushed the noita-entangled-worlds branch from c466736 to f7242a5 Compare December 19, 2024 14:06
donovanglover
donovanglover reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better now, thanks.

Note: I haven't tested this package and it looks like steam-run is rarely used in nixpkgs, so building from source seems ideal

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 19, 2024
@donovanglover
Copy link
Member

ofborg doesn't build the package since steam-unwrapped is an unfreeRedistributable

@TotalTaxAmount TotalTaxAmount mentioned this pull request Dec 29, 2024
Closed
13 tasks
@TotalTaxAmount
Copy link
Contributor

Why not build from source?

great question. I had trouble implementing building from source and found it easier to just grab the release. I can try again later tonight and see if I can get it working. I am pretty new at building a nix pkg.

If you do want to build it from source, here is my version of the package that builds it from source:
https://github.com/NixOS/nixpkgs/pull/368989/files
Not quite sure how to suggest these changes on the pull directly so I will just leave this link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover donovanglover left review comments

@rhendric rhendric rhendric approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Orbsa @rhendric @donovanglover @TotalTaxAmount @wegank @NixOSInfra