Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pomegranate: 0.14.8 -> 1.1.0 #365695

Closed
wants to merge 1 commit into from

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Dec 16, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aucub aucub changed the title pomegranate: 0.14.8 -> 1.1.0 python312Packages.pomegranate: 0.14.8 -> 1.1.0 Dec 16, 2024
Comment on lines 46 to 43
# https://github.com/etal/cnvkit/issues/815
passthru.skipBulkUpdate = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# https://github.com/etal/cnvkit/issues/815
passthru.skipBulkUpdate = true;

Does this version work with our cnvkit?
cc @jbedo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aucub The two lines should be removed either way. But if this breaks cnvkit we might not want to merge before adding packageOverrides to cnvkit.

@aucub aucub force-pushed the pomegranate branch 3 times, most recently from 4ce7c26 to d41eb16 Compare December 17, 2024 09:04
@ofborg ofborg bot requested a review from rybern December 17, 2024 10:48
@aucub aucub closed this Dec 23, 2024
@aucub aucub deleted the pomegranate branch December 23, 2024 18:52
@aucub aucub removed the request for review from rybern December 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants