display3d: init at 0.1.17 #365657
Closed
display3d: init at 0.1.17 #365657
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
benpye
suggested changes
Dec 16, 2024
benpye
approved these changes
Dec 16, 2024
wegank
added
the
12.approvals: 1
steeleduncan
suggested changes
Dec 16, 2024
maintainers/maintainer-list.nix
Outdated
| @@ -18935,6 +18935,12 @@ | |||
| githubId = 93167100; | |||
| keys = [ { fingerprint = "9075 CEF8 9850 D261 6599 641A A2C9 36D5 B88C 139C"; } ]; | |||
| }; | |||
| renpenguin = { | |||
There was a problem hiding this comment.
The change to the maintainers list should be in a separate commit preceeding the one adding the module, with title maintainers: add renpenguin
| pname = "display3d"; | ||
| version = "0.1.17"; | ||
|
|
||
| src = fetchCrate { |
There was a problem hiding this comment.
I don't know if there is anything wrong with fetchCrate, so it is your choice, but normally when the source is on GitHub, the source would be fetched from there with fetchFromGithub
|
Also, all changes should be squashed so that there are only 2 commits. The first with the maintainers list change, the second adding the package |
ofborg
bot
added
8.has: package (new)
renpenguin
force-pushed
the
add/display3d
branch
from
f8983be to
c7dcafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added display3d, a CLI for rendering and animating 3D objects: https://github.com/renpenguin/display3d
Added renpenguin as a package maintainer for display3d
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.