Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oscavmgr: use fetchCargoVendor #365400

Merged
merged 1 commit into from
Dec 16, 2024
Merged

oscavmgr: use fetchCargoVendor #365400

merged 1 commit into from
Dec 16, 2024
+2 −2,430

Conversation

Scrumplex
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 15, 2024
@Scrumplex Scrumplex mentioned this pull request Dec 15, 2024
Closed
13 tasks
@Pandapip1 Pandapip1 self-requested a review December 16, 2024 00:07
@Pandapip1
Copy link
Contributor

Not sure why I wasn't auto-pinged.

Pandapip1
Pandapip1 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean yea, I literally ended up with the exact same patch.

@Pandapip1 Pandapip1 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 16, 2024
@ofborg ofborg bot requested a review from Pandapip1 December 16, 2024 01:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 16, 2024
@Scrumplex Scrumplex added the backport release-24.11 Backport PR automatically label Dec 16, 2024
@Scrumplex Scrumplex merged commit 21d7df2 into NixOS:master Dec 16, 2024
47 of 48 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 16, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 16, 2024
Open
1 task
@Scrumplex Scrumplex deleted the pkgs/oscavmgr/cargo-vendor branch December 16, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scrumplex @Pandapip1