bottles: 51.15 -> 51.17 #365397
Open
bottles: 51.15 -> 51.17 #365397
+173
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
51.16: https://github.com/bottlesdevs/Bottles/releases/tag/51.16
51.17: https://github.com/bottlesdevs/Bottles/releases/tag/51.17
Full diff: bottlesdevs/Bottles@51.15...51.17
A check has been added in
51.16that will makebottlesexit if it is not running as a sandboxed flatpak, I added a patch to remove this check.I added another patch to remove the "Core" tab that was in the preferences.
This tab is not used for quite some time in the official Flatpak and is not functioning anyway.
I opted to patch it out since it will only cause confusion and may lead to unwanted bug report to upstream.
I re-ordered the python3 packages in
propagatedBuildInputsso they are in the same order as the official flatpak (to make it easier to review if we are missing dependencies) and addedpycairoandcharset-normalizersince they are included in the official package.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.