Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell-editor-services: init at 4.1.0 #365312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

powershell-editor-services: init at 4.1.0 #365312

wants to merge 2 commits into from

Conversation

sharpchen
Copy link

@sharpchen sharpchen commented Dec 15, 2024 •
edited
Loading

Resolve #349443

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 15, 2024
@sharpchen sharpchen force-pushed the pwsh_es branch 2 times, most recently from 4ec8229 to 30058a6 Compare December 15, 2024 14:33
@sharpchen
Copy link
Author

Hmm, the first review just got deleted? Whoever you are, thank you. :)

@sharpchen
Copy link
Author

It's a language server for powershell, it should work as long as powershell itself is available. I've test it on my linux machine :)

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 16, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4966

@FliegendeWurst
Copy link
Member

Fails to start with

/nix/store/lnpjxfq8lvqb9j804cb45pb3kww98av3-powershell-editor-services-4.1.0/lib/PowerShellEditorServices/Start-EditorServices.ps1: The term '/nix/store/lnpjxfq8lvqb9j804cb45pb3kww98av3-powershell-editor-services-4.1.0/lib/PowerShellEditorServices/Start-EditorServices.ps1' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

@sharpchen
Copy link
Author

@FliegendeWurst should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: PowerShellEditorServices
5 participants
@sharpchen @nixos-discourse @FliegendeWurst @SuperSandro2000 @NixOSInfra