rclone: use tag in version output to match upstream pre build binaries #365264
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favlh
approved these changes
Dec 14, 2024
|
I double-checked that this compiles and adds the |
SuperSandro2000
changed the title
rclone version match official build
|
We don't use semantic commits. |
Before it was missing a `v`, which caused minor problems with fish shell fish-shell/fish-shell@cc8fa0f.
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
patch-2
branch
from
79485aa to
58d6286
Compare
SuperSandro2000
approved these changes
Dec 15, 2024
github-actions
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-linux: 1-10
labels
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rclone version | headreadsrclone 1.68.2. In the official rclone build, it readsrclone v1.68.2.Currently, it's missing a
v, which caused minor problems: fish-shell/fish-shell@cc8fa0f.This matches https://github.com/rclone/rclone/blob/master/VERSION .
I am not sure whether it's safe to change
$version, so I went for the minimal change. If possible, it might be better to change$version.This is the part of #365135 that's easily fixable.
It's not tested yet.
@SuperSandro2000
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.