nixos/weechat: Rework module #365208
Open
nixos/weechat: Rework module #365208
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
felixsinger
force-pushed
the
nixos/weechat/rework
branch
5 times, most recently
from
d8e479f to
54927cc
Compare
Signed-off-by: Felix Singer <[email protected]>
The environment variable hides the actual state directory of weechat in systemctl. To make it more obvious, use the equivalent CLI parameter. This doesn't change the current behaviour. Signed-off-by: Felix Singer <[email protected]>
This option represents a path. So use the corresponding type. Signed-off-by: Felix Singer <[email protected]>
In preparation for dropping the user home directory, set up the state directory manually. Use the systemd unit options when /var/lib/weechat is used and use systemd-tmpfiles for all other locations. Not sure if it makes any difference. However, it seems systemd tends to control its directories in /var/lib and so it might make more sense to use the existing options of the systemd unit. This doesn't change the current behaviour. Signed-off-by: Felix Singer <[email protected]>
Configuring an user home directory also enables several invocations and mechanisms, e.g. SSH authorized_keys or bashrc, which is bad from a security perspective. The service doesn't need that at all and the environment is set up over different ways now. So drop it. This doesn't change the current behaviour. Signed-off-by: Felix Singer <[email protected]>
Allow specifying a custom weechat package. Signed-off-by: Felix Singer <[email protected]>
felixsinger
force-pushed
the
nixos/weechat/rework
branch
from
54927cc to
e315449
Compare
github-actions
bot
added
10.rebuild-darwin: 0
felixsinger
force-pushed
the
nixos/weechat/rework
branch
2 times, most recently
from
817b7af to
4d6bd30
Compare
felixsinger
force-pushed
the
nixos/weechat/rework
branch
2 times, most recently
from
29789ba to
5056fe3
Compare
weechat can run in TUI or headless mode. Introduce the option `headless` for specifying that. Based on the setting, it configures the appropriate binary in the `binary` option and it also configures the systemd unit accordingly. `headless` is disabled by default. This doesn't change the current behaviour. Signed-off-by: Felix Singer <[email protected]>
felixsinger
force-pushed
the
nixos/weechat/rework
branch
from
5056fe3 to
e9c3b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for descriptions.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.