Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Racket: refactor and add features #365194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Racket: refactor and add features #365194

wants to merge 4 commits into from

Conversation

rc-zb
Copy link
Contributor

@rc-zb rc-zb commented Dec 14, 2024 •
edited
Loading

Refactor racket and racket-minimal.
And add myself to the their maintainer list, which was empty until now.

  • Reduce the closure size of racket-minimal by removing redundant dependencies.
  • Add updateScript.
  • Add writeScript[Bin].
  • Add some package tests.

TODOs

  • Figure out what is really necessary for to build it on Darwin.

Limitations

  • I guess it could be no more possible to extend the minimal distribution to a full one with raco pkg after installation, for lack of runtime dependencies. I don't know if this is part of the public interface of which all breaking changes must be documented.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rc-zb rc-zb force-pushed the refactor-racket branch 2 times, most recently from e5451e8 to 137a24f Compare December 14, 2024 15:24
@rc-zb rc-zb marked this pull request as ready for review December 14, 2024 15:26
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 15, 2024
@rc-zb rc-zb marked this pull request as draft December 16, 2024 12:29
@rc-zb rc-zb changed the title Racket: refactor for smaller minimal distribution Racket: refactor Dec 16, 2024
@rc-zb rc-zb changed the title Racket: refactor Racket: refactor and add features Dec 16, 2024
rc-zb added 3 commits December 25, 2024 16:52
@rc-zb
racket and racket-minimal: refactor
94c22ab 
- Remove redundant dependencies and patch.
- Unify name to `racket`.
- Clean code.
@rc-zb
racket: add writeScript[Bin]
dd2df7a
@rc-zb
racket: add tests
8586a18
@rc-zb rc-zb marked this pull request as ready for review December 25, 2024 09:08
@rc-zb rc-zb mentioned this pull request Jan 1, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rc-zb @SuperSandro2000