Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uiua-unstable: 0.14.0-dev.6 -> 0.14.0-rc.2 #365067

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Coca162
Copy link
Member

@Coca162 Coca162 commented Dec 14, 2024

uiua-lang/uiua@0.14.0-dev.6...0.14.0-rc.2

Also changed update-unstable.sh to update to rc versions since without --version unstable it does not

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Changed `update-unstable.sh` to update to rc versions
@Coca162 Coca162 force-pushed the uiua-unstable-0.14.0-rc.1 branch from 5e846b3 to 60fd99b Compare December 16, 2024 09:02
@Coca162 Coca162 changed the title uiua-unstable: 0.14.0-dev.6 -> 0.14.0-rc.1 uiua-unstable: 0.14.0-dev.6 -> 0.14.0-rc.2 Dec 16, 2024
@Defelo
Copy link
Member

Defelo commented Dec 16, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365067


x86_64-linux

✅ 1 package built:
  • uiua-unstable

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 16, 2024
@TomaSajt
Copy link
Contributor

Also changed update-unstable.sh to update to rc versions since without --version unstable it does not

Didn't know about that flag, thanks!

Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomaSajt TomaSajt merged commit 00442d0 into NixOS:master Dec 16, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants