Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vrcadvert: .NET 6 -> .NET 8 #365007

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

vrcadvert: .NET 6 -> .NET 8 #365007

wants to merge 4 commits into from
+73 −3

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 13, 2024 •
edited
Loading

Tracking: #326335

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird mentioned this pull request Dec 13, 2024
Open
17 tasks
@gepbird
Copy link
Contributor Author

gepbird commented Dec 13, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365007

x86_64-linux

✅ 1 package built:
  • vrcadvert

@gepbird gepbird requested review from Scrumplex and corngood and removed request for Scrumplex December 13, 2024 20:16
Scrumplex
Scrumplex approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 16, 2024
corngood
corngood requested changes Dec 16, 2024
View reviewed changes
pkgs/by-name/vr/vrcadvert/deps.nix Outdated Show resolved Hide resolved
@gepbird
Copy link
Contributor Author

gepbird commented Dec 16, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365007

x86_64-linux

✅ 1 package built:
  • vrcadvert

@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 16, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365007

x86_64-linux

✅ 1 package built:
  • vrcadvert

x86_64-darwin

✅ 1 package built:
  • vrcadvert

aarch64-darwin

✅ 1 package built:
  • vrcadvert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood corngood requested changes

@Scrumplex Scrumplex Scrumplex approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gepbird @Scrumplex @corngood @wegank