Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcb-imdkit: Enforce & fix under strictDeps #364712

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Dec 12, 2024

#326699 (comment)

Fails to cross-compile:

CMake Error at CMakeLists.txt:4 (find_package):
  Could not find a package configuration file provided by "ECM" (requested
  version 0.0.11) with any of the following names:

    ECMConfig.cmake
    ecm-config.cmake

  Add the installation prefix of "ECM" to CMAKE_PREFIX_PATH or set "ECM_DIR"
  to a directory containing one of the above files.  If "ECM" provides a
  separate development package or SDK, be sure it has been installed.

Issue is that extra-cmake-modules is in nativeBuildInputs instead of buildInputs. Move it, and set strictDeps = true to the separation is better enforced even without cross-compilation.

Cross now fail at Qt5 cross-compilation, which is at least "the well-known issue" I guess…

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@OPNA2608 OPNA2608 added the backport release-24.11 Backport PR automatically label Dec 12, 2024
@OPNA2608 OPNA2608 mentioned this pull request Dec 12, 2024
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 12, 2024
@OPNA2608 OPNA2608 force-pushed the fix/xcb-imdkit-cross branch from 46cc64b to c21e9e7 Compare December 12, 2024 22:19
@OPNA2608 OPNA2608 changed the title xcb-imdkit: Fix cross-compilation & under strictDeps xcb-imdkit: Enforce & fix under strictDeps Dec 12, 2024
@ofborg ofborg bot requested a review from poscat0x04 December 13, 2024 16:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 13, 2024
@OPNA2608 OPNA2608 merged commit 23aa77b into NixOS:master Dec 29, 2024
57 of 58 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 29, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant