hellwal: init at 1.0.2 #364360
Merged
hellwal: init at 1.0.2 #364360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
pluiedev
suggested changes
Dec 11, 2024
|
How about now? Is it fine? Oh. it's not... |
github-actions
bot
added
8.has: maintainer-list (update)
pluiedev
suggested changes
Dec 11, 2024
|
Thanks you all for helping me :D I think it's ready right? |
|
Needs to be squashed into just two commits before merge at least :p
|
ofborg
bot
added
10.rebuild-darwin: 0
danihek
force-pushed
the
hellwal-package
branch
from
90cdae9 to
5157ddd
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
|
Okay it's squashed :) |
ofborg
bot
added
10.rebuild-darwin: 0
github-actions
bot
added
10.rebuild-linux: 0
|
Okay, so:
I think it's fine now. Thanks for patience and help, I learned a lot. |
pluiedev
reviewed
Dec 12, 2024
pkgs/by-name/he/hellwal/package.nix
Outdated
Comment on lines
29
to
32
| platforms = [ | ||
| "x86_64-linux" | ||
| "x86_64-darwin" | ||
| ]; |
There was a problem hiding this comment.
Im pretty sure it failed previously before on aarch64, both linux and darwin, when I used platforms.all
There was a problem hiding this comment.
Okay it passed, I feel dumb.
There was a problem hiding this comment.
platforms.all - hellwal: init at 1.0.2
There was a problem hiding this comment.
I'm not sure about platforms.all either. Set it to platforms.unix for now.
There was a problem hiding this comment.
Done: hellwal: init at 1.0.2
danihek
force-pushed
the
hellwal-package
branch
from
713eac3 to
705757d
Compare
danihek
force-pushed
the
hellwal-package
branch
from
705757d to
64b5ea8
Compare
|
@ofborg build hellwal |
ofborg
bot
added
10.rebuild-darwin: 1
10.rebuild-linux: 1
10.rebuild-darwin: 0
|
philiptaron
approved these changes
Dec 13, 2024
|
@pluiedev thanks for the kind and welcoming way you interacted in this PR. |
|
@pluiedev Thank you very much for helping me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I wanted to add hellwal here, it's color palette generator, something like pywal.
Here's a link to repo: hellwal
It's my first contribution here, so I don't really know If I did all correctly, please keep that in mind :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.