ocamlPackages.tls-eio: init at 1.0.4, and remove incorrect optimization from mdx

[vog]

Add the missing variant ocamlPackages.tls-eio of the ocamlPackages.tls-* packages.

This requires the removal of an incorrect optimization from the mdx package, which is explained in the commit message:

The original purpose of this optimization was described by its author as follows:

Strip optional dependencies from logs to make the closure smaller as this
package contains a binary

However, that optimization is incorrect because it affects not only the command line tool (output "mdx.bin") but also the mdx library (output "mdx").

Pull request #290291 recognized this issue, but merely moved this optimization from development/ocaml-modules/mdx/default.nix to top-level/ocaml-packages.nix, so everyone affected can help themselves via attribute overriding. As such, it didn't fix the original problem, i.e. that this optimization is simply incorrect. Moreover, that doesn't help if we ever want an affected library, such as "tls-eio", to be officially included in nixpkgs.

This commit fixes the root of the problem by removing the incorrect optimization.

Please note that this commit is not intended to discourage the re-introduction of such an optimization. However, a new variant of this optimization should only be included if it is correct, i.e. reduces just "mdx.bin" without making "mdx" incompatible with every package that directly or indirectly depends on the "logs" library.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[vbgl]

Suggested change

	mdx
	(mdx.override { inherit logs; })

Instead of the (controversial) first commit, you can simply locally override the mdx library to use the version of logs of your liking.

[vog]

@vbgl I followed your advice and force-pushed a variant that doesn't contain any controversial changes.

Instead of the (controversial) first commit, you can simply locally override the mdx library to use the version of logs of your liking.

While I still believe that we should somehow limit the effects of the overriding logs to mdx.bin, while binding the mdx library to the unmodified logs as that would simplify everything downstream, I have no idea how to do that, and I don't want that to block the inclusion of ocamlPackages.tls-eio.

[nix-backports]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] ocamlPackages.tls-eio: init at 1.0.4, and remove incorrect optimization from mdx #364191

[nix-backports]

Git push to origin failed for release-24.11 with exitcode 1