Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ente-auth: backport auth lockscreen fixes #363985

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Dec 10, 2024

Backport of a fix for a potential bypass of Ente Auth's lockscreen: ente-io/ente#3545

Because of breaking changes in 4.1.0+, only the fix is backported (see #357503).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz niklaskorz mentioned this pull request Dec 10, 2024
13 tasks
@niklaskorz niklaskorz marked this pull request as ready for review December 10, 2024 19:15
@niklaskorz
Copy link
Contributor Author

niklaskorz commented Dec 10, 2024

Revert to draft while we consider backporting 4.1.6 to NixOS 24.11 instead.

@niklaskorz niklaskorz marked this pull request as draft December 10, 2024 20:08
@niklaskorz niklaskorz closed this Dec 11, 2024
@niklaskorz niklaskorz deleted the ente-auth-lockscreen-fix-24.11 branch December 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant