-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dioxus-cli: 0.5.7 -> 0.6.0 #363956
dioxus-cli: 0.5.7 -> 0.6.0 #363956
Conversation
55ae4cb
to
452ad26
Compare
452ad26
to
9fbce35
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ofborg failure seams unrelated, I'm going to check it when i'm at my Laptop if so i'm going to merge this.
This was fixed in #364542. |
@CathalMullan I'm not sure if there are breaking changes in the CLI interface or just that the interactive parts of the CLI look different, if there aren't any breaking changes we can backport this to 24.11. |
@xanderio The overall CLI interface hasn't changed much, but there are some breaking changes around options that I can see. e.g. |
Description of changes
dioxus-cli
to v0.6.0optimizations
cargo featurenixfmt-rfc-style
Tested by running a Desktop, Web, Android and iOS version of the hello world example simultaneously on aarch64-darwin.
Here's the flake I used.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.