Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dioxus-cli: 0.5.7 -> 0.6.0 #363956

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

CathalMullan
Copy link
Member

@CathalMullan CathalMullan commented Dec 10, 2024

Description of changes

  • updated dioxus-cli to v0.6.0
  • enabled optimizations cargo feature
  • formatted with nixfmt-rfc-style
  • added changelog

Tested by running a Desktop, Web, Android and iOS version of the hello world example simultaneously on aarch64-darwin.

Here's the flake I used.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@iynaix
Copy link
Contributor

iynaix commented Dec 12, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363956


x86_64-linux

✅ 1 package built:
  • dioxus-cli

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
Copy link
Contributor

@xanderio xanderio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ofborg failure seams unrelated, I'm going to check it when i'm at my Laptop if so i'm going to merge this.

@xanderio xanderio added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 13, 2024
@xanderio
Copy link
Contributor

The ofborg failure seams unrelated, I'm going to check it when i'm at my Laptop if so i'm going to merge this.

This was fixed in #364542.

@xanderio xanderio merged commit 6eb40af into NixOS:master Dec 14, 2024
23 of 25 checks passed
@xanderio
Copy link
Contributor

@CathalMullan I'm not sure if there are breaking changes in the CLI interface or just that the interactive parts of the CLI look different, if there aren't any breaking changes we can backport this to 24.11.

@CathalMullan
Copy link
Member Author

@xanderio The overall CLI interface hasn't changed much, but there are some breaking changes around options that I can see. e.g. --platform fullstack in v0.5.7 has been changed to --fullstack. So I wouldn't backport.

@CathalMullan CathalMullan deleted the dioxus-cli-v0.6.0 branch December 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants