Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.rns: 0.8.6 -> 0.8.7, python312Packages.nomadnet: 0.5.4 -> 0.5.5 #363954

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 10, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member Author

fabaff commented Dec 10, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363954


x86_64-linux

✅ 12 packages built:
  • python311Packages.lxmf
  • python311Packages.lxmf.dist
  • python311Packages.nomadnet
  • python311Packages.nomadnet.dist
  • python311Packages.rns
  • python311Packages.rns.dist
  • python312Packages.lxmf
  • python312Packages.lxmf.dist
  • python312Packages.nomadnet
  • python312Packages.nomadnet.dist
  • python312Packages.rns
  • python312Packages.rns.dist

@qbit
Copy link
Contributor

qbit commented Dec 10, 2024

hah! #363947 :D

I was gonna wait on nomadnet because I wanted to add myself as maintainer. Yours works for me though.

@qbit
Copy link
Contributor

qbit commented Dec 10, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363954


x86_64-linux

✅ 12 packages built:
  • python311Packages.lxmf
  • python311Packages.lxmf.dist
  • python311Packages.nomadnet
  • python311Packages.nomadnet.dist
  • python311Packages.rns
  • python311Packages.rns.dist
  • python312Packages.lxmf
  • python312Packages.lxmf.dist
  • python312Packages.nomadnet
  • python312Packages.nomadnet.dist
  • python312Packages.rns
  • python312Packages.rns.dist

@qbit qbit mentioned this pull request Dec 10, 2024
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@ofborg ofborg bot requested a review from qbit December 11, 2024 11:35
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 11, 2024
@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 11, 2024
@Erethon
Copy link
Contributor

Erethon commented Dec 12, 2024

rns 0.8.8 was released 5 hours ago fyi

Copy link
Contributor

@Erethon Erethon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions to update to the latest RNS (0.8.8) and nomadnet (0.5.6) versions.

@@ -12,7 +12,7 @@

buildPythonPackage rec {
pname = "nomadnet";
version = "0.5.4";
version = "0.5.5";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.5.5";
version = "0.5.6";

@@ -21,7 +21,7 @@ buildPythonPackage rec {
owner = "markqvist";
repo = "NomadNet";
rev = "refs/tags/${version}";
hash = "sha256-4dHxwTHDe8aE/FFtf9jhOO1Wf3uU7KjBa/ngj8o5iMY=";
hash = "sha256-uT5W/jea6vQ3XvtaTFcgvUz6K7FB3rEhtZGpjm0w7WY=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash = "sha256-uT5W/jea6vQ3XvtaTFcgvUz6K7FB3rEhtZGpjm0w7WY=";
hash = "sha256-dwymJIsMDeVsG7eF45CgUPlZf3sEdwnxZ8OxT+gEQCs=";

@@ -13,7 +13,7 @@

buildPythonPackage rec {
pname = "rns";
version = "0.8.6";
version = "0.8.7";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.8.7";
version = "0.8.8";

@@ -22,7 +22,7 @@ buildPythonPackage rec {
owner = "markqvist";
repo = "Reticulum";
rev = "refs/tags/${version}";
hash = "sha256-LvtiK/j6EuXqBOj04x6aWoLOfhukFQxVsEzT/SWvcHU=";
hash = "sha256-QDX+pOzn4o3gNL16e/26VYQAROChxAT5eEFcsokg7uc=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash = "sha256-QDX+pOzn4o3gNL16e/26VYQAROChxAT5eEFcsokg7uc=";
hash = "sha256-Vsh5C0IlOz8/Jw0ya1bOGsNiBQTXJwTWUBcDFs5Zp+0=";

@FliegendeWurst FliegendeWurst added the 2.status: needs-changes This PR needs changes by the author label Dec 15, 2024
@fabaff
Copy link
Member Author

fabaff commented Dec 16, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363954


x86_64-linux

✅ 12 packages built:
  • python311Packages.lxmf
  • python311Packages.lxmf.dist
  • python311Packages.nomadnet
  • python311Packages.nomadnet.dist
  • python311Packages.rns
  • python311Packages.rns.dist
  • python312Packages.lxmf
  • python312Packages.lxmf.dist
  • python312Packages.nomadnet
  • python312Packages.nomadnet.dist
  • python312Packages.rns
  • python312Packages.rns.dist

@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 16, 2024
@fabaff fabaff merged commit 169063d into NixOS:master Dec 16, 2024
23 of 24 checks passed
@fabaff fabaff deleted the nomadnet-bump branch December 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: needs-changes This PR needs changes by the author 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants