Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.{jaeger-client,opentracing}: drop #363656

Merged
merged 3 commits into from
Dec 15, 2024
Merged

python3Packages.{jaeger-client,opentracing}: drop #363656

merged 3 commits into from
Dec 15, 2024

Conversation

tomodachi94
Copy link
Member

Unmaintained since 2023:
https://github.com/opentracing/opentracing-python

OpenTracing is deprecated in favor of OpenTelemetry:
#261927

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Dec 9, 2024
@nix-owners nix-owners bot requested a review from natsukium December 9, 2024 17:42
@tomodachi94 tomodachi94 requested a review from Rakesh4G December 9, 2024 17:43
@tomodachi94 tomodachi94 marked this pull request as draft December 9, 2024 17:46
@tomodachi94
Copy link
Member Author

tomodachi94 commented Dec 9, 2024 •
edited
Loading

jaegertracing should also be dropped. It is deprecated upstream, also in favor of OpenTelemetry.

@tomodachi94 tomodachi94 force-pushed the drop/python3Packages.opentracing branch from beeffb7 to 7a3d963 Compare December 9, 2024 20:15
@tomodachi94 tomodachi94 marked this pull request as ready for review December 9, 2024 20:17
@tomodachi94 tomodachi94 changed the title python3Packages.opentracing: drop python3Packages.{jaegertracing,opentracing}: drop Dec 9, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
@tomodachi94 tomodachi94 added the 5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue label Dec 10, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@tomodachi94
Copy link
Member Author

Waiting on a reply from @Rakesh4G (not likely, judging from Nixpkgs activity) or for one week from Sunday to pass (okay to merge this on 2024-12-15).

wolfgangwalther
wolfgangwalther approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

nixos/doc/manual/release-notes/rl-2505.section.md Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 15, 2024
@tomodachi94 tomodachi94 changed the title python3Packages.{jaegertracing,opentracing}: drop python3Packages.{jaeger-client,opentracing}: drop Dec 15, 2024
@tomodachi94 tomodachi94 force-pushed the drop/python3Packages.opentracing branch from 7a3d963 to 045a51c Compare December 15, 2024 19:45
@wolfgangwalther wolfgangwalther merged commit dd0af4f into NixOS:master Dec 15, 2024
23 of 25 checks passed
@tomodachi94 tomodachi94 deleted the drop/python3Packages.opentracing branch December 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees
No one assigned
Labels
5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomodachi94 @AndersonTorres @wolfgangwalther @wegank