bartender: add passthru.updateScript, format with nixfmt-rfc-style, use lib.platforms.darwin, 5.2.3 -> 5.2.7
#363633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
DontEatOreo
force-pushed
the
update-bartender-5
branch
from
0963e77 to
283f492
Compare
DontEatOreo
force-pushed
the
update-bartender-5
branch
from
d029c43 to
2e3ee0f
Compare
stepbrobd
reviewed
Dec 11, 2024
DontEatOreo
force-pushed
the
update-bartender-5
branch
from
2e3ee0f to
9d241e0
Compare
getchoo
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Feel free to ping in a couple days if there are no other reviews
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363633
aarch64-darwin
✅ 1 package built:
- bartender
getchoo
added
the
12.approvals: 1
|
|
@DimitarNestorov merge not permitted (#305350): |
DimitarNestorov
approved these changes
Dec 12, 2024
DimitarNestorov
added
12.approvals: 2
getchoo
added
the
12.approved-by: package-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.