Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

houdini: fix fhsenv version #363168

Merged
merged 1 commit into from
Dec 11, 2024
Merged

houdini: fix fhsenv version #363168

merged 1 commit into from
Dec 11, 2024

Conversation

Stunkymonkey
Copy link
Contributor

part of #336576

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 8, 2024
@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 8, 2024 21:20
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 9, 2024
Pandapip1
Pandapip1 approved these changes Dec 10, 2024
View reviewed changes
pkgs/by-name/ho/houdini/package.nix Outdated Show resolved Hide resolved
@Stunkymonkey Stunkymonkey force-pushed the houdini-fhsenv-version branch from b473614 to 86731c1 Compare December 10, 2024 23:52
@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 11, 2024
@getchoo getchoo merged commit 45344f2 into NixOS:master Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @Pandapip1 @getchoo