Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel_8: init at 8.0.0 #362414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

boltzmannrain
Copy link
Contributor

@boltzmannrain boltzmannrain commented Dec 6, 2024

Started with copying bazel_7 and adapted it, notable changes:

  • bazelDeps now builds on Darwin in sandbox=true which was previously failing on power management tweaks
  • using lndir -silent for less build logs
  • had to disable module_deps feature to avoid getting .. does not depend on a module exporting .. errors on clang/macos importing intrinsics
  • on macos adding -fno-aligned-allocation on sdk <10.13 to avoid build error saying it isn't supported on <10.13

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@boltzmannrain

This comment was marked as outdated.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 7, 2024
@boltzmannrain boltzmannrain changed the title bazel_8: init at 8.0.0rc7 bazel_8: init at 8.0.0rc8 Dec 8, 2024
@boltzmannrain

This comment was marked as outdated.

@boltzmannrain

This comment was marked as outdated.

@boltzmannrain

This comment was marked as outdated.

@boltzmannrain

This comment was marked as outdated.

@boltzmannrain boltzmannrain marked this pull request as ready for review December 11, 2024 00:30
@nix-owners nix-owners bot requested a review from Profpatsch December 11, 2024 00:32
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Dec 11, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 11, 2024
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Dec 11, 2024
@boltzmannrain boltzmannrain marked this pull request as draft December 12, 2024 12:29
@ofborg ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 12, 2024
@boltzmannrain
Copy link
Contributor Author

@ofborg build bazel_8

@boltzmannrain
Copy link
Contributor Author

on x86_64-darwin following looks like a build agent setup issue?

       > FATAL: mkdir('/var/tmp/_bazel__nixbld1'): (error: 13): Permission denied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant