Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-show-player: init at 0.6.4 #362243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented Dec 5, 2024

Closes #361815

Currently complains that it couldn't dlopen JACK libs, despite LD_LIBRARY_PATH being set... I really don't understand why

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium December 5, 2024 23:19
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 6, 2024
@getchoo
Copy link
Member

getchoo commented Dec 8, 2024

@ofborg build linux-show-player linux-show-player.passthru.tests python312Packages.jack-client python312Packages.jack-client.passthru.tests python312Packages.pyalsa python312Packages.pyalsa.passthru.tests

@getchoo
Copy link
Member

getchoo commented Dec 11, 2024

@ofborg build linux-show-player linux-show-player.passthru.tests python312Packages.jack-client python312Packages.jack-client.passthru.tests python312Packages.pyalsa python312Packages.pyalsa.passthru.tests

homepage = "https://jackclient-python.readthedocs.io/";
changelog = "https://jackclient-python.readthedocs.io/en/${version}/version-history.html";
license = with lib.licenses; [ mit ];
maintainers = with lib.maintainers; [ pluiedev ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with lib.maintainers; [ pluiedev ];
maintainers = with lib.maintainers; [ pluiedev ];
platforms = lib.intersectLists python.meta.platforms libjack2.meta.platforms;

description = "Python bindings for the Advanced Linux Sound Architecture (ALSA)";
homepage = "http://www.alsa-project.org";
license = with lib.licenses; [ lgpl2Plus ];
maintainers = with lib.maintainers; [ pluiedev ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with lib.maintainers; [ pluiedev ];
maintainers = with lib.maintainers; [ pluiedev ];
platforms = lib.intersectLists alsa-lib.meta.platforms python.meta.platforms;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Linux show player
2 participants