Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: 256.8 -> 256.9 #361862

Merged
merged 1 commit into from
Dec 12, 2024
Merged

systemd: 256.8 -> 256.9 #361862

merged 1 commit into from
Dec 12, 2024
+2 −2

Conversation

Princemachiavelli
Copy link
Contributor

@Princemachiavelli Princemachiavelli commented Dec 4, 2024 •
edited
Loading

systemd/systemd@v256.8...v256.9

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Princemachiavelli Princemachiavelli added the backport staging-24.11 Backport PR automatically label Dec 4, 2024
@ofborg ofborg bot requested review from flokli and kloenk December 5, 2024 15:18
@philiptaron
Copy link
Contributor

What's on the list before undrafting this, @Princemachiavelli?

@Princemachiavelli Princemachiavelli marked this pull request as ready for review December 11, 2024 23:14
@Princemachiavelli
Copy link
Contributor Author

@philiptaron There were some build errors due to other issues in staging but those seem fixed now. I'm fine with this as-is now. (systemd and systemdMinimal both build).

Since Systemd 257 was released so quickly after this minor update I'm also fine just waiting for #356818 unless that will take a while.

@philiptaron
Copy link
Contributor

I'll give this a build overnight like I did with 257. Since 24.11 will be on 256 for its whole life, there's value in merging this and backporting to 24.11 staging, in my view.

philiptaron added a commit to philiptaron/flock.nix that referenced this pull request Dec 12, 2024
@philiptaron
Test out NixOS/nixpkgs#361862 on my system
a81cff6
@philiptaron
Copy link
Contributor

I booted into this and everything looks great. I'll run a few tests.

@philiptaron
Copy link
Contributor

The following tests don't eval on master:

  1. nixosTests.systemd-initrd-bridge
  2. nixosTests.systemd-repart.create-root

The following tests are failing on master for me:

  1. nixosTests.systemd-initrd-vconsole (hangs with 100% CPU use)
  2. nixosTests.systemd-journal-gateway (fails with error about the service not starting)

The rest of the tests pass, so these are what I ran on this PR:

nixosTests.systemd
nixosTests.systemd-analyze
nixosTests.systemd-binfmt.basic
nixosTests.systemd-binfmt.chroot
nixosTests.systemd-binfmt.ldPreload
nixosTests.systemd-binfmt.preserveArgvZero
nixosTests.systemd-boot.basic
nixosTests.systemd-boot.basicXbootldr
nixosTests.systemd-boot.edk2-uefi-shell
nixosTests.systemd-boot.entryFilenameXbootldr
nixosTests.systemd-boot.extraEntries
nixosTests.systemd-boot.extraFiles
nixosTests.systemd-boot.fallback
nixosTests.systemd-boot.garbage-collect-entry
nixosTests.systemd-boot.memtest86
nixosTests.systemd-boot.memtestSortKey
nixosTests.systemd-boot.netbootxyz
nixosTests.systemd-boot.no-bootspec
nixosTests.systemd-boot.secureBoot
nixosTests.systemd-boot.specialisation
nixosTests.systemd-boot.switch-test
nixosTests.systemd-boot.update
nixosTests.systemd-boot.windows
nixosTests.systemd-bpf
nixosTests.systemd-confinement
nixosTests.systemd-coredump
nixosTests.systemd-credentials-tpm2
nixosTests.systemd-cryptenroll
nixosTests.systemd-escaping
nixosTests.systemd-homed
nixosTests.systemd-initrd-btrfs-raid
nixosTests.systemd-initrd-luks-empty-passphrase
nixosTests.systemd-initrd-luks-fido2
nixosTests.systemd-initrd-luks-keyfile
nixosTests.systemd-initrd-luks-password
nixosTests.systemd-initrd-luks-tpm2
nixosTests.systemd-initrd-luks-unl0kr
nixosTests.systemd-initrd-modprobe
nixosTests.systemd-initrd-networkd.basic
nixosTests.systemd-initrd-networkd.doFlush
nixosTests.systemd-initrd-networkd.dontFlush
nixosTests.systemd-initrd-networkd-openvpn
nixosTests.systemd-initrd-networkd-ssh
nixosTests.systemd-initrd-shutdown
nixosTests.systemd-initrd-simple
nixosTests.systemd-initrd-swraid
nixosTests.systemd-initrd-vlan
nixosTests.systemd-journal
nixosTests.systemd-journal-upload
nixosTests.systemd-lock-handler
nixosTests.systemd-machinectl
nixosTests.systemd-misc
nixosTests.systemd-networkd
nixosTests.systemd-networkd-bridge
nixosTests.systemd-networkd-dhcpserver
nixosTests.systemd-networkd-dhcpserver-static-leases
nixosTests.systemd-networkd-ipv6-prefix-delegation
nixosTests.systemd-networkd-vrf
nixosTests.systemd-no-tainted
nixosTests.systemd-nspawn
nixosTests.systemd-nspawn-configfile
nixosTests.systemd-oomd
nixosTests.systemd-portabled
nixosTests.systemd-repart.after-initrd
nixosTests.systemd-repart.basic
nixosTests.systemd-resolved
nixosTests.systemd-shutdown
nixosTests.systemd-sysupdate
nixosTests.systemd-sysusers-immutable
nixosTests.systemd-sysusers-mutable
nixosTests.systemd-timesyncd
nixosTests.systemd-timesyncd-nscd-dnssec
nixosTests.systemd-user-linger
nixosTests.systemd-user-tmpfiles-rules
nixosTests.systemd-userdbd

I'm starting this test run now.

philiptaron
philiptaron approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following tests don't eval on master:

  1. nixosTests.systemd-initrd-bridge
  2. nixosTests.systemd-repart.create-root

The following tests are failing on master for me:

  1. nixosTests.systemd-initrd-vconsole (hangs with 100% CPU use)
  2. nixosTests.systemd-journal-gateway (fails with error about the service not starting)

The rest of the tests pass. ✅

@ElvishJerricco ElvishJerricco merged commit 7afc01b into NixOS:staging Dec 12, 2024
40 of 42 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 12, 2024

Successfully created backport PR for staging-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 12, 2024
Merged
1 task
@philiptaron philiptaron mentioned this pull request Dec 12, 2024
Merged
13 tasks
@Princemachiavelli Princemachiavelli deleted the systemd-update branch December 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@flokli flokli Awaiting requested review from flokli

@kloenk kloenk Awaiting requested review from kloenk

@aanderse aanderse Awaiting requested review from aanderse

@arianvp arianvp Awaiting requested review from arianvp

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

Assignees
No one assigned
Labels
6.topic: systemd 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ backport staging-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Princemachiavelli @philiptaron @ElvishJerricco