glpi-agent: init at 1.11 #361746
Merged
glpi-agent: init at 1.11 #361746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liberodark
force-pushed
the
glpi-agent
branch
3 times, most recently
from
2e22483 to
6853375
Compare
|
Also this need a backport to 24.11 if is possible is tested and used on 24.11 |
liberodark
force-pushed
the
glpi-agent
branch
3 times, most recently
from
66fc977 to
71d6837
Compare
github-actions
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
8.has: package (new)
GaetanLepage
requested changes
Dec 7, 2024
liberodark
force-pushed
the
glpi-agent
branch
from
71d6837 to
1b16074
Compare
github-actions
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
liberodark
force-pushed
the
glpi-agent
branch
from
1b16074 to
b7bb021
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
liberodark
force-pushed
the
glpi-agent
branch
from
7c27122 to
3a1bcf4
Compare
liberodark
force-pushed
the
glpi-agent
branch
3 times, most recently
from
50cef94 to
63f0317
Compare
GaetanLepage
requested changes
Dec 20, 2024
github-actions
bot
added
10.rebuild-darwin: 0
liberodark
force-pushed
the
glpi-agent
branch
3 times, most recently
from
1f5d11b to
ada0599
Compare
GaetanLepage
requested changes
Dec 20, 2024
Comment on lines
116
to
122
| nativeInstallCheckInputs = [ | ||
| versionCheckHook | ||
| ]; | ||
|
|
||
| versionCheckProgramArg = [ "--version" ]; | ||
|
|
||
| doInstallCheck = true; |
There was a problem hiding this comment.
Suggested change
| nativeInstallCheckInputs = [ | |
| versionCheckHook | |
| ]; | |
| versionCheckProgramArg = [ "--version" ]; | |
| doInstallCheck = true; | |
| nativeInstallCheckInputs = [ | |
| versionCheckHook | |
| ]; | |
| versionCheckProgram = "${placeholder "out"}/bin/GLPI-Agent"; | |
| versionCheckProgramArg = [ "--version" ]; | |
| doInstallCheck = true; |
There was a problem hiding this comment.
I think is not necessary.
There was a problem hiding this comment.
Have fix issue you can build on your side.
liberodark
force-pushed
the
glpi-agent
branch
2 times, most recently
from
73191e1 to
4fb750f
Compare
liberodark
force-pushed
the
glpi-agent
branch
from
4fb750f to
0cf1b13
Compare
|
GaetanLepage
approved these changes
Dec 20, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #361741
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.