Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envision: autopatchelf after build #359156

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Pandapip1
Copy link
Contributor

Continuation of #337340

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 force-pushed the envision-autopatchelf-nofuckup branch from 316ee60 to cb45ad8 Compare December 15, 2024 03:26
@Pandapip1
Copy link
Contributor Author

Rebased; I think the staging I was based off of was broken.

@layus layus merged commit 145f9be into NixOS:staging Dec 16, 2024
42 of 43 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 16, 2024

Backport failed for staging-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.11
git worktree add -d .worktree/backport-359156-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-359156-to-staging-24.11
git switch --create backport-359156-to-staging-24.11
git cherry-pick -x 504c876ec6e152569049838ad6d738e1d00deee3 62b63369425bdede6d6f9a4092f39d8283dfcc46 cb45ad8681f07c57ebff47a7b827cb9927f6d028

Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me.

Thanks for addressing the comments in previous iterations of this PR.

@Pandapip1
Copy link
Contributor Author

Manually backported: #365640

@Pandapip1 Pandapip1 deleted the envision-autopatchelf-nofuckup branch December 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport staging-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants