-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envision: autopatchelf after build #359156
envision: autopatchelf after build #359156
Conversation
3c1e202
to
a8c2e92
Compare
a8c2e92
to
316ee60
Compare
316ee60
to
cb45ad8
Compare
Rebased; I think the staging I was based off of was broken. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-24.11
git worktree add -d .worktree/backport-359156-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-359156-to-staging-24.11
git switch --create backport-359156-to-staging-24.11
git cherry-pick -x 504c876ec6e152569049838ad6d738e1d00deee3 62b63369425bdede6d6f9a4092f39d8283dfcc46 cb45ad8681f07c57ebff47a7b827cb9927f6d028 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me.
Thanks for addressing the comments in previous iterations of this PR.
Manually backported: #365640 |
Continuation of #337340
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.