Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.textblob: remove with lib #358687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idlip
Copy link
Contributor

@idlip idlip commented Nov 24, 2024

repair #358680

@FliegendeWurst

Sorry and thanks!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda changed the title pythonPackages.textblob remove with lib + set nativeCheckInputs pythonPackages.textblob: remove with lib + set nativeCheckInputs Nov 24, 2024
@idlip
Copy link
Contributor Author

idlip commented Nov 24, 2024

ohho, this is a stopper. It is not building due to nltk version.

You get wordnet not found
Attempted to load corpora/wordnet

Upstream issues: sloria/TextBlob#474
sloria/TextBlob#473

@idlip
Copy link
Contributor Author

idlip commented Nov 24, 2024

Actually package works fine without tests, but it is failing in testing phase.
Should I disable it?

pythonPackages.nltk package has it disabled due to it downloading data.

# Tests require some data, the downloading of which is impure. It would

@idlip
Copy link
Contributor Author

idlip commented Nov 24, 2024

without nativeCheckInputs = [ pytestCheckHook ];

It builds and runs fine. I will let it be this way?

@idlip idlip changed the title pythonPackages.textblob: remove with lib + set nativeCheckInputs pythonPackages.textblob: remove with lib Nov 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 25, 2024
@@ -21,15 +21,13 @@ buildPythonPackage rec {

dependencies = [ nltk ];

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment explaining why tests are disabled. (apparently they require network access)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants