Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: 0-unstable-2024-10-24 -> 0-unstable-2024-11-25 #356391

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 16, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zowoq zowoq added the 2.status: work-in-progress This PR isn't done label Nov 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 16, 2024
@Mindavi
Copy link
Contributor

Mindavi commented Nov 17, 2024

Tried this out, but seems to break the CSS on subpages of my hydra instance:

image

Javascript console in my browser
GET
http://localhost:3000/static/fontawesome/css/all.css
[HTTP/1.1 404 Not Found 27ms]

GET
http://localhost:3000/static/bootstrap/js/bootstrap.min.js
[HTTP/1.1 404 Not Found 31ms]

GET
http://localhost:3000/static/bootstrap/css/bootstrap.min.css
[HTTP/1.1 404 Not Found 27ms]

Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content. [jquery-3.4.1.min.js:2:52150](http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js)
GET
http://localhost:3000/static/bootstrap/js/bootstrap.min.js
[HTTP/1.1 404 Not Found 15ms]

Loading failed for the <script> with source “http://localhost:3000/static/bootstrap/js/bootstrap.min.js”. [nixpkgs:19:101](http://localhost:3000/project/nixpkgs)
jQuery.Deferred exception: $.fn.popover is undefined @http://localhost:3000/static/js/common.js:53:5
e@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:29453
Deferred/then/l/</t<@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:29755
setTimeout handler*Deferred/then/l/<@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:29964
c@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:27742
fireWith@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:28487
fire@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:28523
c@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:27742
fireWith@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:28487
ready@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:31460
B@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:31239
EventListener.handleEvent*@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:31608
@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:220
@http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js:2:225
 undefined [jquery-3.4.1.min.js:2:31008](http://localhost:3000/static/js/jquery/jquery-3.4.1.min.js)
Uncaught TypeError: $.fn.popover is undefined
    <anonymous> http://localhost:3000/static/js/common.js:53
    jQuery 13
[common.js:53:5](http://localhost:3000/static/js/common.js)
GET
http://localhost:3000/favicon.ico
[HTTP/1.1 404 Not Found 0ms]

@zowoq zowoq changed the title hydra: 0-unstable-2024-10-24 -> 0-unstable-2024-11-16 hydra: 0-unstable-2024-10-24 -> 0-unstable-2024-11-25 Nov 26, 2024
@zowoq zowoq removed the 2.status: work-in-progress This PR isn't done label Nov 26, 2024
@zowoq zowoq marked this pull request as ready for review November 26, 2024 02:52
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rebuilt my system with this and seems to work well for me. Had some trouble building hydra (running the tests, actually) under high load but I already knew that was an issue. Diff looks good and I don't see any obvious regressions right now.

@Mindavi Mindavi merged commit 2fd17b5 into NixOS:master Nov 27, 2024
40 of 41 checks passed
@zowoq zowoq deleted the hydra-meson branch November 27, 2024 23:25
@zowoq
Copy link
Contributor Author

zowoq commented Dec 11, 2024

Opened another PR for hydra+nix-eval-jobs: #364142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants