Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openbao: init at 2.0.3 #354366

Merged
merged 2 commits into from
Dec 14, 2024
Merged

openbao: init at 2.0.3 #354366

merged 2 commits into from
Dec 14, 2024

Conversation

brianmay
Copy link
Contributor

@brianmay brianmay commented Nov 8, 2024 •
edited
Loading

Add OpenBao as a package with the initial version as 2.0.1.

Homepage: https://openbao.org/
GitHub: https://github.com/openbao/openbao
Changelog: https://github.com/openbao/openbao/blob/main/CHANGELOG.md

This is has updates from #334485. Will close this PR if/when changes get merged there.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 8, 2024
@brianmay brianmay mentioned this pull request Nov 8, 2024
Closed
13 tasks
@brianmay
Copy link
Contributor Author

brianmay commented Nov 8, 2024 •
edited
Loading

I am not comfortable with the postInstall = stuff. Not convinced any of this is required. And it doesn't seem to be having the intended affect. Might remove it.

  • rename binary to baob. Maybe I need this. For some reason it builds as bin/openbaob but documentation seems to refer to bin/baob.
  • bash autocompletions - don't see this in upstream code anywhere.
  • wrapper to add gawk and glibc to path - don't think it is required. And wrapper didn't actually do anything.

@brianmay
Copy link
Contributor Author

brianmay commented Nov 8, 2024

I added back the rename binary to baob. Not sure if this is the best way or not.

I think the version test should be working now.

@brianmay
Copy link
Contributor Author

brianmay commented Nov 9, 2024

@cipherboy Can I please get you to review this PR?

@sivizius
Copy link
Contributor

sivizius commented Nov 10, 2024 •
edited
Loading

Duplicate of #334485, even though slightly newer #334485 was closed

@brianmay
Copy link
Contributor Author

brianmay commented Nov 10, 2024 •
edited
Loading

Duplicate of #334485, even though slightly newer

I said as much already.

But #334485, seems stale (feedback was given 1 month ago and not acknowledged in any way), and it doesn't look like it is going to get updated any time soon. As I can't update that PR, I created a new PR.

@brianmay
Copy link
Contributor Author

Darwin openbao.passthru.tests process appears to be stuck. All other CI OK.

@brianmay
Copy link
Contributor Author

The original PR was closed.

cipherboy
cipherboy approved these changes Nov 15, 2024
View reviewed changes
Copy link

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, it took me a while to get to this. I've not tested this as I don't have a Nix environment but nothing looks surprising here comparing it with the documentation.

I will note we just released v2.0.3 today to fix some security issues but otherwise I'm happy if that is updated in a subsequent PR.

Thank you for this! I'll add it to the website's documentation once this lands.

@brianmay
Copy link
Contributor Author

Hopefully will update to 2.0.3 tomorrow.

@KiaraGrouwstra
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354366

x86_64-linux

✅ 1 package built:
  • openbao

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/24

@Ben9986
Copy link
Contributor

Ben9986 commented Dec 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354366

x86_64-linux

✅ 1 package built:
  • openbao

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 10, 2024
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Dec 10, 2024
wolfgangwalther
wolfgangwalther previously requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch and squash the commits, so that you end up with two commits:

  • maintainers: add brianmay
  • openbao: init at 2.0.3

@wolfgangwalther wolfgangwalther changed the title Add pkg openbao openbao: init at 2.0.3 Dec 12, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354366

x86_64-linux

✅ 1 package built:
  • openbao

x86_64-darwin

✅ 1 package built:
  • openbao

aarch64-darwin

✅ 1 package built:
  • openbao

@wolfgangwalther wolfgangwalther merged commit d41191d into NixOS:master Dec 14, 2024
24 of 25 checks passed
@justinrubek justinrubek mentioned this pull request Dec 14, 2024
Closed
@brianmay brianmay deleted the add-pkg-openbao branch December 14, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@cipherboy cipherboy cipherboy approved these changes

@Ben9986 Ben9986 Ben9986 approved these changes

@KiaraGrouwstra KiaraGrouwstra KiaraGrouwstra approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@brianmay @sivizius @KiaraGrouwstra @nixos-discourse @Ben9986 @wolfgangwalther @cipherboy @wegank