treewide: handle *Phases variables __structuredAttrs-agnostically (round 2)

[ShamrockLee]

This PR clears the remaining non-__structuredAttrs-agnostic appending to the *Phase list not caught by #339117.

For the "insert the new phase before certain phase" operation, this commit adds a new Bash function replaceElement to setup.sh to provide a more graceful solution to the string-replacement hack in #339117 and previous implementations. (Previous discussion: #339117 (comment)).

Cc: @philiptaron @wolfgangwalther

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

I think we should not introduce any new helper to stdenv here, but instead fix the 4 cases "properly" as suggested in the other comments. This will remove all those hacks depending on order of the preXPhases.

[wolfgangwalther]

I think we should not introduce any new helper to stdenv here, but instead fix the 4 cases "properly" as suggested in the other comments. This will remove all those hacks depending on order of the preXPhases.

I opened #360450 to address those special cases. If we do this, then we don't need introduce any new helpers here.

[ShamrockLee]

I opened #360450 to address those special cases. If we do this, then we don't need introduce any new helpers here.

@wolfgangwalther Thank you for fixing them. I dropped the commits already adjusted by #360450.

[ShamrockLee]

There are still a lot of rebuilds. I'll re-target this feature branch to staging.

[ShamrockLee]

@ofborg build tests.devShellTools.nixos
@ofborg build tests.dotnet
@ofborg build tests.testers
@ofborg build tests.trivial-builders.references
@ofborg build tests.vim