gradle: 8.10 -> 8.10.2 #351437
Merged
gradle: 8.10 -> 8.10.2 #351437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg eval |
wegank
added
the
12.approvals: 1
britter
force-pushed
the
britter/gradle-8.10.2
branch
from
ed0aa73 to
d88011a
Compare
wegank
removed
the
12.approvals: 1
|
Result of 2 packages failed to build:
51 packages built:
|
|
Never mind, some hiccup in my remote builder setup: Result of 53 packages built:
|
katexochen
approved these changes
Oct 28, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-351437-to-release-24.05 origin/release-24.05
cd .worktree/backport-351437-to-release-24.05
git switch --create backport-351437-to-release-24.05
git cherry-pick -x d88011ab4d73752232374976ac7f3ee9d35f111c |
|
I've looked into the conflict. 24.05 is still on Gradle 8.7 and updating it to 8.10.2 requires more changes than just updating the version. I think we should leave it like it is and wait for 24.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.