Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoenv: init at 2024-10-16 #349058

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

autoenv: init at 2024-10-16 #349058

wants to merge 2 commits into from
+68 −0

Conversation

clebs
Copy link
Member

@clebs clebs commented Oct 16, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 16, 2024
@clebs clebs force-pushed the autoenv branch 4 times, most recently from e4dfac0 to 8205ab7 Compare October 16, 2024 15:13
@clebs clebs added 8.has: module (new) This PR adds a module in `nixos/` and removed 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 16, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 16, 2024
@clebs clebs added 8.has: module (update) This PR changes an existing module in `nixos/` and removed 8.has: module (new) This PR adds a module in `nixos/` labels Oct 17, 2024
@clebs
autoenv: init at 2024-10-16
c5172a5 
Signed-off-by: Borja Clemente <[email protected]>
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Oct 22, 2024
@clebs
Copy link
Member Author

clebs commented Oct 30, 2024

1 package built:
autoenv

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349058

aarch64-darwin

✅ 1 package built:
  • autoenv

aarch64-linux

✅ 1 package built:
  • autoenv

x86_64-linux

✅ 1 package built:
  • autoenv

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024
FliegendeWurst
FliegendeWurst requested changes Dec 16, 2024
View reviewed changes
pkgs/by-name/au/autoenv/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autoenv/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/au/autoenv/package.nix Outdated Show resolved Hide resolved
@FliegendeWurst FliegendeWurst added the 2.status: needs-changes This PR needs changes by the author label Dec 16, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst requested changes

@husjon husjon husjon approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: needs-changes This PR needs changes by the author 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clebs @husjon @FliegendeWurst @wegank @h7x4