Update graylog

[bbenno]

• Update Graylog 6.0
• Remove Graylog 5.1 (due to EOL)
• In NixOS set default version to 6.0 (prev. was now removed version 5.1)

Migration Guide 5.1 → 5.2

Migration Guide 5.2 → 6.0

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[leona-ya]

Generally I'm okay with removing the package, but not with the package default change.

[leona-ya]

I'm not so happy with silently changing the default for all state versions. It's probably the easiest to add an assertion for old state versions like in https://github.com/NixOS/nixpkgs/pull/345625/files#diff-5834a9cebfb2c9d2d6863e68be9c225f325f77d1c5a1a5e55f66fa3298995a93R90 or only set the default when the state version is >=25.05

[bbenno]

Thank you very much for pointing out the assertion pattern that I was not aware of.

However, after grep'ing for this pattern and recognizing that it is only used for UniFi, I decided to go with the pattern PostgreSQL uses:

in the options part

nixpkgs/nixos/modules/services/databases/postgresql.nix

Lines 89 to 91 in 924dd67

	package = mkPackageOption pkgs "postgresql" {
	example = "postgresql_15";
	};

In the implementation part (config = mkIf cfg.enable)

nixpkgs/nixos/modules/services/databases/postgresql.nix

Lines 491 to 512 in 924dd67

	services.postgresql.package = let
	mkThrow = ver: throw "postgresql_${ver} was removed, please upgrade your postgresql version.";
	mkWarn = ver: warn ''
	The postgresql package is not pinned and selected automatically by
	`system.stateVersion`. Right now this is `pkgs.postgresql_${ver}`, the
	oldest postgresql version available and thus the next that will be
	removed when EOL on the next stable cycle.
	See also https://endoflife.date/postgresql
	'';
	base = if versionAtLeast config.system.stateVersion "24.11" then pkgs.postgresql_16
	else if versionAtLeast config.system.stateVersion "23.11" then pkgs.postgresql_15
	else if versionAtLeast config.system.stateVersion "22.05" then pkgs.postgresql_14
	else if versionAtLeast config.system.stateVersion "21.11" then mkWarn "13" pkgs.postgresql_13
	else if versionAtLeast config.system.stateVersion "20.03" then mkThrow "11"
	else if versionAtLeast config.system.stateVersion "17.09" then mkThrow "9_6"
	else mkThrow "9_5";
	in
	# Note: when changing the default, make it conditional on
	# ‘system.stateVersion’ to maintain compatibility with existing
	# systems!
	mkDefault (if cfg.enableJIT then base.withJIT else base);

[bbenno]

Generally I'm okay with removing the package, but not with the package default change.

I'll split the PR up into dedicated updates for each version (that can then be backported on an individual level) and another for the removal of Graylog 5.1.