Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.libarchive-c: apply patch fixing a test with recent libarchive versions #348582

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Oct 14, 2024

See comments in #341705 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348582


x86_64-linux

✅ 20 packages built:
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • diffoscopeMinimal
  • diffoscopeMinimal.dist
  • diffoscopeMinimal.man
  • opendrop
  • opendrop.dist
  • python311Packages.libarchive-c
  • python311Packages.libarchive-c.dist
  • python311Packages.ratarmount
  • python311Packages.ratarmount.dist
  • python311Packages.ratarmountcore
  • python311Packages.ratarmountcore.dist
  • python312Packages.libarchive-c
  • python312Packages.libarchive-c.dist
  • ratarmount (python312Packages.ratarmount)
  • ratarmount.dist (python312Packages.ratarmount.dist)
  • python312Packages.ratarmountcore
  • python312Packages.ratarmountcore.dist

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed build failure for be as well. Thank you!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 15, 2024
@vcunat vcunat merged commit 35cd8cb into NixOS:master Oct 23, 2024
33 checks passed
@vcunat
Copy link
Member

vcunat commented Oct 23, 2024

Thanks 🙂 Looks small enough for master.

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants