nixos/godns: init module #348290
Open
nixos/godns: init module #348290
+91
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
62ee801 to
309ce77
Compare
NixOSInfra
added
the
12. first-time contribution
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
309ce77 to
375e072
Compare
github-actions
bot
added
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
375e072 to
625eb98
Compare
michaelvanstraten
force-pushed
the
add-godns-service
branch
4 times, most recently
from
bd611bc to
54f25d0
Compare
michaelvanstraten
force-pushed
the
add-godns-service
branch
2 times, most recently
from
5059144 to
9b368a5
Compare
misuzu
reviewed
Dec 16, 2024
| type = types.nullOr types.path; | ||
| }; | ||
|
|
||
| additionalRestartTriggers = mkOption { |
There was a problem hiding this comment.
The systemd service will restart when the value of cfg.configFile changes. Is this really needed?
There was a problem hiding this comment.
When using something like sops-nix templates, the answer is sadly yes. Because the path of the generated template does not change even if the secret changes.
There was a problem hiding this comment.
Because the path of the generated template does not change even if the secret changes.
How does this option help then?
misuzu
reviewed
Dec 16, 2024
Initial implementation of the GoDNS service module. This module allows users to enable and configure the GoDNS service on their NixOS system. It includes options for specifying the GoDNS package and the path to the configuration file.
michaelvanstraten
force-pushed
the
add-godns-service
branch
from
02cf028 to
91bf5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new NixOS module for the GoDNS service, which allows users to enable and configure the GoDNS service on their NixOS system.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.