-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sleek-todo: init at 2.0.14 #347525
Merged
Merged
sleek-todo: init at 2.0.14 #347525
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteSudoer
force-pushed
the
init-sleek
branch
from
October 10, 2024 23:11
87762b5
to
84c56f8
Compare
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Oct 11, 2024
FliegendeWurst
requested changes
Nov 1, 2024
ByteSudoer
force-pushed
the
init-sleek
branch
from
November 3, 2024 21:26
84c56f8
to
307515e
Compare
FliegendeWurst
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion.
ByteSudoer
force-pushed
the
init-sleek
branch
from
November 8, 2024 10:11
307515e
to
c061ca3
Compare
FliegendeWurst
approved these changes
Nov 8, 2024
cp -a ${appimageContents}/usr/share/icons $out/share | ||
install -Dm 444 ${appimageContents}/sleek.desktop $out/share/applications | ||
substituteInPlace $out/share/applications/sleek.desktop \ | ||
--replace-warn 'Exec=AppRun' 'Exec=${pname}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
--replace-warn 'Exec=AppRun' 'Exec=${pname}' | |
--replace-warn 'Exec=AppRun' 'Exec=sleek-todo' |
FliegendeWurst
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Packaging Sleek: todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
Metadata
Note: This package was called
sleek-todo
because another package wit the namesleek
already exists.Closes #347108
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.