Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleek-todo: init at 2.0.14 #347525

Merged
merged 1 commit into from
Dec 15, 2024
Merged

sleek-todo: init at 2.0.14 #347525

merged 1 commit into from
Dec 15, 2024

Conversation

ByteSudoer
Copy link
Contributor

Things done

Packaging Sleek: todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
Metadata

Closes #347108

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/sl/sleek-todo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sl/sleek-todo/package.nix Show resolved Hide resolved
pkgs/by-name/sl/sleek-todo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sl/sleek-todo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sl/sleek-todo/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion.

pkgs/by-name/sl/sleek-todo/package.nix Outdated Show resolved Hide resolved
cp -a ${appimageContents}/usr/share/icons $out/share
install -Dm 444 ${appimageContents}/sleek.desktop $out/share/applications
substituteInPlace $out/share/applications/sleek.desktop \
--replace-warn 'Exec=AppRun' 'Exec=${pname}'
Copy link
Member

@FliegendeWurst FliegendeWurst Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--replace-warn 'Exec=AppRun' 'Exec=${pname}'
--replace-warn 'Exec=AppRun' 'Exec=sleek-todo'

#277994

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@sivizius sivizius mentioned this pull request Nov 10, 2024
13 tasks
@FliegendeWurst FliegendeWurst changed the title sleek: init at 2.0.14 sleek-todo: init at 2.0.14 Dec 15, 2024
@FliegendeWurst FliegendeWurst merged commit 45c7a57 into NixOS:master Dec 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: sleek
2 participants