Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super-productivity: build from source #334933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pineapplehunter
Copy link
Contributor

@pineapplehunter pineapplehunter commented Aug 15, 2024

Builds super-productivity from source and updates to 11.0.0.

Description of changes

This PR does a number of things.

  • Builds package from source
  • Updates the package from version to 11.0.0
  • Moved files to pkgs/by-name
  • Adds support for aarch64-linux (only checked build)

Because the upstream package-lock.json is out of sync, the package-lock.json is manually generated. If the generated lock file is too big (this seems to be a significant issue #327064), I have opened another PR before which only updates the appimage file #332671. Edit: this is not relevant because it uses npm-lockfile-fix now. I'll keep the appimage version #332671 so we can update before the review of this PR.

@offlinehacker This does make this package a bit harder to maintain (although I don't think it would be too hard to make a update script) so I would like to know your opinion. Edit: added an update script

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 15, 2024
@ofborg ofborg bot requested a review from offlinehacker August 15, 2024 20:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 15, 2024
@pineapplehunter
Copy link
Contributor Author

Added a update script

@pineapplehunter pineapplehunter force-pushed the supprod-from-source branch 2 times, most recently from a8fd73a to 51e59af Compare September 8, 2024 09:49
@pineapplehunter
Copy link
Contributor Author

Updated to 10.0.4

@pineapplehunter
Copy link
Contributor Author

Updated to 10.0.9

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4589

@pineapplehunter
Copy link
Contributor Author

Updated to 10.0.10

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1986

@pineapplehunter
Copy link
Contributor Author

Let's wait to merge this until the update for npm-lockfile-fix (0.1.1) is merged. It should fix the issue that I had to patch.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@pineapplehunter
Copy link
Contributor Author

Fixed conflict and updated to 10.1.1.
This is ready for review but it can wait until this release cycle ends.

@pineapplehunter pineapplehunter force-pushed the supprod-from-source branch 2 times, most recently from e18a652 to 00ac037 Compare November 12, 2024 12:02
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 12, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 12, 2024
@Aleksanaa Aleksanaa added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 13, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants