Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pympress: fix gstreamer support #319525

Merged
merged 1 commit into from
Jun 16, 2024
Merged

pympress: fix gstreamer support #319525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkgs/applications/office/pympress/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
, libcanberra-gtk3
, poppler_gi
, withGstreamer ? stdenv.isLinux
, gst_all_1
, withVLC ? stdenv.isLinux
}:

Expand All @@ -29,7 +30,16 @@ python3Packages.buildPythonApplication rec {
buildInputs = [
gtk3
poppler_gi
] ++ lib.optional withGstreamer libcanberra-gtk3;
] ++ lib.optionals withGstreamer [
libcanberra-gtk3
gst_all_1.gstreamer
gst_all_1.gst-plugins-base
gst_all_1.gst-plugins-bad
gst_all_1.gst-plugins-ugly
(gst_all_1.gst-plugins-good.override {gtkSupport = true;})
gst_all_1.gst-libav
gst_all_1.gst-vaapi
Comment on lines +35 to +41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gst_all_1.gstreamer
gst_all_1.gst-plugins-base
gst_all_1.gst-plugins-bad
gst_all_1.gst-plugins-ugly
(gst_all_1.gst-plugins-good.override {gtkSupport = true;})
gst_all_1.gst-libav
gst_all_1.gst-vaapi
gst_all_1.gstreamer
gst_all_1.gst-plugins-base
gst_all_1.gst-plugins-bad
(gst_all_1.gst-plugins-good.override {gtkSupport = true;})

That's what I take from the upstream docs https://github.com/Cimbali/pympress/blob/fc5ebfc79b5255ea801e4935aaa33f7bcadc595d/README.md#media-and-autoplay

I am not sure if the others are even used or loaded on demand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the video playback is completely handled by gstreamer so I would assume the instance of gstreamer is independent from the rest of the package and can access all available plugins/extensions.
In the upstream docs it says: "and plugins gstreamer-good/-bad/-ugly based on which codecs you need" so why remove gst_all_1.gst-plugins-ugly?
I have taken the example from the wiki https://nixos.wiki/wiki/GStreamer for full gstreamer support.

];

propagatedBuildInputs = with python3Packages; [
pycairo
Expand Down