Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstream-electrs: init at 0.4.1-unstable-2024-11-25 #318195

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

phlip9
Copy link
Contributor

@phlip9 phlip9 commented Jun 8, 2024

Description of changes

This PR packages Blockstream/electrs, an efficient BTC chain indexer. It forms part of the backend for https://blockstream.info, but many others also use it.

Blockstream/electrs is actually a fork of romanz/electrs, though the two projects diverged several years ago. romanz/electrs is also packaged in nixpkgs as electrs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phlip9 phlip9 force-pushed the phlip9/add-blockstream-electrs branch from cbe405f to 9b02ecb Compare June 10, 2024 18:57
@phlip9
Copy link
Contributor Author

phlip9 commented Jun 10, 2024

Looks like some of the upstream's dev-dependencies (electrumd, elementsd) fail to compile on anything not- x86_64-linux even when *_SKIP_DOWNLOAD=1, so I've disabled tests on all other platforms.

@phlip9 phlip9 force-pushed the phlip9/add-blockstream-electrs branch 2 times, most recently from 9398b27 to 1692a4d Compare November 15, 2024 01:26
@phlip9
Copy link
Contributor Author

phlip9 commented Nov 15, 2024

@FliegendeWurst Thanks for the review! I also took the opportunity to update the package, since it was broken with the current bitcoind version in nixpkgs.

@phlip9 phlip9 force-pushed the phlip9/add-blockstream-electrs branch from 1692a4d to 2c5da77 Compare November 18, 2024 21:35
@phlip9
Copy link
Contributor Author

phlip9 commented Nov 18, 2024

Rebased on master and removed the vendored Cargo.lock in favor of useFetchCargoVendor

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 20, 2024
@phlip9 phlip9 force-pushed the phlip9/add-blockstream-electrs branch from 2c5da77 to 0971ef5 Compare November 20, 2024 20:22
@phlip9
Copy link
Contributor Author

phlip9 commented Nov 20, 2024

Removed buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [darwin.apple_sdk.frameworks.Security];

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2024
@phlip9
Copy link
Contributor Author

phlip9 commented Dec 10, 2024

Anything else blocking this from landing?

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@phlip9 phlip9 force-pushed the phlip9/add-blockstream-electrs branch from 0971ef5 to 5ae74b8 Compare December 10, 2024 23:49
@phlip9
Copy link
Contributor Author

phlip9 commented Dec 10, 2024

  • Update 0.4.1-unstable-2024-09-30 -> 0.4.1-unstable-2024-11-25
  • Remove bitcoind-v28.patch since my PR landed
  • Gate preCheck on doCheck so non-x86_64-linux doesn't accidentally break when it can't build the bitcoind and electrum integration test dependencies.
-  preCheck = ''
+  preCheck = lib.optionalString doCheck ''
     export BITCOIND_EXE=${bitcoind}/bin/bitcoind
     export ELECTRUMD_EXE=${electrum}/bin/electrum
   '';

@FliegendeWurst FliegendeWurst changed the title blockstream-electrs: init at 2024-05-29 blockstream-electrs: init at 0.4.1-unstable-2024-11-25 Dec 11, 2024
@FliegendeWurst FliegendeWurst merged commit f4cee62 into NixOS:master Dec 11, 2024
44 of 45 checks passed
@phlip9 phlip9 deleted the phlip9/add-blockstream-electrs branch December 12, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants