devpod: init at 0.4.1

[maxbrunet]

Description of changes

This adds 2 new packages: devpod (CLI written in Go) and devpod-desktop (GUI written in Rust with Tauri and a TypeScript front-end). The GUI invokes/wraps the CLI.

Closes #239252

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[dit7ya]

Does the package work correctly?

Last time I tried to package it I stumbled upon this issue loft-sh/devpod#329.

[maxbrunet]

@dit7ya The CLI is fully functional. The GUI also appears fully functional with minor graphical bugs (e.g. some icons missing on Linux, impossible to drag window on macOS)

[maxbrunet]

Actually I had forgotten to enable the sandbox on macOS on the first build, I hit this issue now: h4llow3En/mac-notification-sys#28

Not sure if there is an easy workaround, I have marked the GUI as supported on Linux only for now.

(Personally, I do not plan to use the GUI, so I'd be happy with packaging the CLI only.)

[aacebedo]

@maxbrunet did you use it with docker provider? I tried but I think it has a design flow preventing it to work on nix. I mentioned it in the issue opened by @dit7ya

[aacebedo]

Ok. I checked your version and it is working because the binary is linked statically to the libc. So copying the file in the container works.

[maxbrunet]

did you use it with docker provider?

Yes, it has been working well (note: I use DOCKER_PATH=podman)

it is working because the binary is linked statically to the libc.

Cgo is disabled, so no libc involved

[aacebedo]

did you use it with docker provider?

Yes, it has been working well (note: I use DOCKER_PATH=podman)

it is working because the binary is linked statically to the libc.

Cgo is disabled, so no libc involved
It is working now correctly on my side. Can we merge this?
@maxbrunet did you push the PR in ready for review thread? (https://discourse.nixos.org/t/prs-ready-for-review/3032)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2783

[aacebedo]

@SuperSandro2000 Can you have a lootk to this please?

[bbigras]

The cli seems to work 👍 . The rest is a bit complex for me to review.

[bbigras]

What is up with the ofborg-eval test not passing?

[aacebedo]

@maxbrunet can you have a look here? 23.11 is coming and it would be nice to have this in the stable release if it is not too late yet.

[maxbrunet]

Thank you @pbsds for the review!

[pbsds]

Result of nixpkgs-review pr 251858 run on x86_64-linux 1

2 packages built:

• devpod
• devpod-desktop

[pbsds]

• package path fits guidelines
• package name fits guidelines
• package version fits guidelines
• package build on x86_64-linux
• executables tested on x86_64-linux
• meta.description is set and fits guidelines
• meta.license fits upstream license
• meta.platforms is set
• meta.maintainers is set
• build time only dependencies are declared in nativeBuildInputs
• source is fetched using the appropriate function
• the list of phases is not overridden
• when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.
• patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
• patches that are remotely available are fetched rather than vendored

[bbigras]

Anyone has an example of using devpod with a nix flake? I guess a simple devcontainer.json file.