Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: 12 -> 13 #234858

Closed
wants to merge 1 commit into from
Closed

gcc: 12 -> 13 #234858

wants to merge 1 commit into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented May 29, 2023

Switch default gcc from 12 branch to 13 branch. Typical expected breakages are listed in https://gcc.gnu.org/gcc-13/porting_to.html

The simplest ones are missing includes due to header dependency changes. More interesting are added assters for rebind allocator. We'll need a hydra run for that.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi trofi marked this pull request as draft May 29, 2023 19:40
@trofi
Copy link
Contributor Author

trofi commented May 29, 2023 •
edited
Loading

Switching to draft. I'll undraft it when I'll fix all the known issues related to my nixos/system.

After that I plan to request a hydra jobset to find the rest of failures. I think we expect order ~200 broken packages nixpkgs-wide.

Known failures (and fixes):

@trofi
gcc: 12 -> 13
8798bfc 
Switch default gcc from 12 branch to 13 branch. Typical expected
breakages are listed in https://gcc.gnu.org/gcc-13/porting_to.html

The simplest ones are missing includes due to header dependency changes.
More interesting are added assters for `rebind` allocator. We'll need
a hydra run for that.
@trofi
Copy link
Contributor Author

trofi commented Jul 15, 2023

Don't plan finishing it.

@trofi trofi closed this Jul 15, 2023
@trofi trofi deleted the gcc-12-to-13 branch July 15, 2023 07:32
@kirillrdy
Copy link
Member

@trofi thank you for all your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @kirillrdy