-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift: 5.5.3 -> 5.6.2 #186476
swift: 5.5.3 -> 5.6.2 #186476
Conversation
Thanks for taking the time to do this! I'm testing these changes out locally. It appears that the SHA for swift-format needs an update. |
Welcome! This PR took me quite a while and I changed from 5.6.1 to 5.6.2 at some point, so it's possible that some other SHAs need updates as well. Meanwhile, I updated the one for swift-format. |
+1 Verified build on my Ubuntu setup. All validation tests pass. Simple programs compile and function as expected. |
Great work! I recommend adding yourself as a maintainer @Trundle! |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your work. Yes, it is a lot of work updating because of how Apple structures the subrepos and build, which make it basically impossible to automate. There are also some internal inconsistencies in how they invoke Python that don't comply with PEP 394.
How is x86_64-linux failing but aarch64-linux succeeding? |
I haven't seen this before and the previous runs were all successful. Possibly a flaky test or some issue with the runner (e.g. out of memory) |
Maybe we should disable the test(s) that are flaky. |
the failing test is |
I personally think it's a bit hasty to call a test flaky if it only failed once for not-so-clear reasons, but if that is what is needed to move this PR forward, I'm happy to disable it. |
Result of 1 package built:
|
Hi @Trundle , I am getting following error. Is there any plan to support this in future ?
|
We never had Darwin support here. It would be a separate, none trivial effort to enable it. |
@ofborg eval |
Darwin support is tracked in #37473. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes