-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add dynect aRecord support #327
Conversation
FYI, Unit tests coming.. |
a0339c8
to
4345cc5
Compare
{ | ||
options = { | ||
name = mkOption { | ||
default = "charon-${uuid}-${name}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change charon
to nixops
. (There are a few places where we use charon
for backward compatibility, but obviously that's not needed for new resource types.)
4345cc5
to
c9de328
Compare
Did you already manage to put dyn into nixpkgs, and add a test? |
I didn't get time to add tests, but will do that soon. I did add dyn in nixpkgs but have to figure out why my PR is failing. Here is the PR: NixOS/nixpkgs#9380 |
Dyn is now in nixpkgs. |
This needs cleaning up. |
Hello! Thank you for this PR. In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0 My hope is that by adding types and more thorough automated testing, However, because of the major changes, it has become likely that this If you would like to see this merge, please bring it up to date with Thank you again for the work you've done here, I am sorry to be Graham |
No description provided.