Fix resource leak

Nitro · Jul 21, 2020 · 284b55b · 284b55b
1 parent 0a22096
commit 284b55b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/internal/service/provider/web.go b/internal/service/provider/web.go
@@ -210,6 +210,11 @@ func (w Web) validAnchorBrowser(ctx context.Context, endpoint string, anchor str
 	if err != nil {
 		return false, fmt.Errorf("failed to create the browser page: %w", err)
 	}
+	defer func() {
+		if perr := page.CloseE(); perr != nil {
+			err = fmt.Errorf("failed to close the browser tab: %w", perr)
+		}
+	}()
 
 	if _, err = page.Context(pctx, pctxCancel).SetExtraHeadersE(w.genHeaders(endpoint)); err != nil {
 		return false, fmt.Errorf("failed to set the headers at the browser page: %w", err)
@@ -222,11 +227,6 @@ func (w Web) validAnchorBrowser(ctx context.Context, endpoint string, anchor str
 	if err := page.WaitLoadE(); err != nil {
 		return false, fmt.Errorf("failed to wait for the page to load: %w", err)
 	}
-	defer func() {
-		if perr := page.CloseE(); perr != nil {
-			err = fmt.Errorf("failed to close the browser tab: %w", perr)
-		}
-	}()
 
 	result, err := page.EvalE(true, "", "document.documentElement.innerHTML", nil)
 	if err != nil {