-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically selects config section matching AWS_PROFILE #272
base: master
Are you sure you want to change the base?
Conversation
Need to use |
The CLA at https://www.clahub.com/agreements/Nike-Inc/fastbreak isn't loading for me (tried both Brave and Firefox). |
miss-read one of the elements required - we'll have to think about that added requirement being added manually..
I tested this and it seems to work (ignore my previous review) |
In theory, we could add a question to the |
I'm late to the party here. Am starting to use gimme-aws-creds again after several years of not needing it. |
When a user has exported an AWS_PROFILE environment variable, the logic in this PR will find a matching section in ~/.okta_aws_login_config, if configured.
Description
See motivation section below.
To enable the new feature for a given profile, the corresponding section in ~/.okta_aws_login_config must add a new attribute e.g., the following...
...would activate the profile when the AWS_PROFILE environment variable is set to
foo
Related Issue
#271
Motivation and Context
E.g., Existing usage with many explicit profile references:
Optional new usage for those of us who wish to type less:
How Has This Been Tested?
I'm using it locally. If I have more time in the near future, I may provide additional documentation and testing. I tried to make the new feature at least a little bit self-discoverable without external documentation. I also did some manual testing for the existing cases.
For some reason, if I run
nosetests --verbosity=2 tests/
, I get errors like the ones below, even though I ranpip3 install -r requirements.txt
:Screenshots (if appropriate):
Types of changes
Checklist: