Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent High Alert Threshold range #3765

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Navid200
Copy link
Collaborator

This PR only imposes a range on the persistent high alert threshold.

I will address the other requirements in another PR to make this one independent and easier to review.

The following images show the toast message shown when the input is out of range, for the two units, and is rejected.

Screenshot_20241109-214259 Screenshot_20241109-214346

@Navid200
Copy link
Collaborator Author

I don't really know what you're doing here. Why don't you just return false from the onPreferenceChange listener if you want to reject the new value?

Done

If we want to continue improving localization this should be a string resource format string that has these values formatted in to it.

Done

For good localization you shouldn't be building the string yourself with concatenation. Instead use a format string. See how xdrip_software_changed_format is handled for an example.

Done

@jamorham jamorham merged commit 9ad109f into NightscoutFoundation:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants